Date: Thu, 30 Nov 2017 08:56:05 +0100 From: Michal Meloun <melounmichal@gmail.com> To: Jan Beich <jbeich@FreeBSD.org>, Mark Linimon <linimon@FreeBSD.org> Cc: svn-ports-head@freebsd.org, arm@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r455173 - in head: multimedia/ffmpeg multimedia/libass net/asterisk13 net/freerdp x11/rxvt-unicode Message-ID: <d0ae6a5c-e584-da93-80cb-6726c3b3d320@freebsd.org> In-Reply-To: <inds-43t3-wny@FreeBSD.org> References: <201711300702.vAU72oII050996@repo.freebsd.org> <inds-43t3-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 30.11.2017 8:35, Jan Beich wrote: > Mark Linimon <linimon@FreeBSD.org> writes: > >> Author: linimon >> Date: Thu Nov 30 07:02:49 2017 >> New Revision: 455173 >> URL: https://svnweb.freebsd.org/changeset/ports/455173 >> >> Log: >> For ports that set particular flags/options for armv6, also set them >> for armv7. > [...] >> Modified: head/multimedia/ffmpeg/Makefile >> ============================================================================== >> --- head/multimedia/ffmpeg/Makefile Thu Nov 30 07:01:14 2017 (r455172) >> +++ head/multimedia/ffmpeg/Makefile Thu Nov 30 07:02:49 2017 (r455173) >> @@ -54,6 +54,7 @@ OPTIONS_GROUP_LICENSE= GPL3 NONFREE >> >> OPTIONS_DEFINE_amd64= MMX SSE >> OPTIONS_DEFINE_armv6= VFP NEON >> +OPTIONS_DEFINE_armv7= VFP NEON > > Are you sure about disabling VFP and NEON by default? If so bump PORTREVISION. > Otherwise, back this part out. > It's not enabling instead of disabling ? > $ cc -v > FreeBSD clang version 5.0.0 (tags/RELEASE_500/final 312559) (based on LLVM 5.0.0svn) > Target: armv7-unknown-freebsd12.0-gnueabihf > Thread model: posix > InstalledDir: /nxb-bin/usr/bin > > $ cc -dM -E -</dev/null 2>&1 | fgrep -i -e vfp -e neon > #define __ARM_NEON 1 > #define __ARM_NEON_FP 0x4 > #define __ARM_NEON__ 1 > #define __ARM_PCS_VFP 1 > #define __ARM_VFPV3__ 1 > #define __VFP_FP__ 1 > >> +CONFIGURE_ARGS_armv7= --disable-fast-unaligned > > Can anyone on arm@ list confirm bug 200609 affects armv7 as well? > I'd prefer to avoid the pessimization otherwise. > We supports unaligned access for armv6 starting from r300701 so yes, it's supported for armv7 from beginning.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d0ae6a5c-e584-da93-80cb-6726c3b3d320>