From owner-cvs-all  Fri Sep 14 15:48: 2 2001
Delivered-To: cvs-all@freebsd.org
Received: from coffee.q9media.com (coffee.q9media.com [216.94.229.19])
	by hub.freebsd.org (Postfix) with ESMTP
	id ED8B237B406; Fri, 14 Sep 2001 15:47:53 -0700 (PDT)
Received: (from mike@localhost)
	by coffee.q9media.com (8.11.2/8.11.3) id f8EMpe232513;
	Fri, 14 Sep 2001 18:51:40 -0400 (EDT)
	(envelope-from mike)
Date: Fri, 14 Sep 2001 18:51:40 -0400
From: Mike Barcroft <mike@FreeBSD.org>
To: Alexey Zelkin <phantom@FreeBSD.org>
Cc: Ruslan Ermilov <ru@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libc/stdlib strfmon.c
Message-ID: <20010914185140.A32495@coffee.q9media.com>
Mail-Followup-To: Mike Barcroft <mike@FreeBSD.org>,
	Alexey Zelkin <phantom@FreeBSD.org>, Ruslan Ermilov <ru@FreeBSD.org>,
	cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
References: <200109060926.f869QS033887@freefall.freebsd.org> <20010906155654.I18362@sunbay.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20010906155654.I18362@sunbay.com>; from ru@FreeBSD.org on Thu, Sep 06, 2001 at 03:56:54PM +0300
Organization: The FreeBSD Project
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

Ruslan Ermilov <ru@FreeBSD.org> writes:
> On Thu, Sep 06, 2001 at 02:26:28AM -0700, Alexey Zelkin wrote:
> > phantom     2001/09/06 02:26:28 PDT
> > 
> >   Modified files:
> >     lib/libc/stdlib      strfmon.c 
> >   Log:
> >   correctly wrap macros with { }
> >   
> >   Revision  Changes    Path
> >   1.2       +4 -3      src/lib/libc/stdlib/strfmon.c
> > 
> Nope, this is incorrect.  You didn't read the whole thread.
> The correct fix it is to wrap macros in ``{ } while(0)'':
> 
> #define PRINT(CH) do {						\
> 	if (dst >= s + maxsize)					\
> 		goto e2big_error;				\
> 	*dst++ = CH;						\
> } while(0)
> 
> See style(9) for more details.

Alexey,
Is there a reason you haven't fixed this yet?

Best regards,
Mike Barcroft

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message