Date: Thu, 17 Jun 2004 17:28:43 +0200 From: Max Laier <max@love2party.net> To: freebsd-current@freebsd.org Cc: amd64@freebsd.org Subject: Re: [current tinderbox] failure on amd64/amd64 Message-ID: <200406171728.51186.max@love2party.net> In-Reply-To: <20040617132111.GO9228@elvis.mu.org> References: <20040617094725.45EE37306D@freebsd-current.sentex.ca> <20040617133207.29a6f935.liamfoy@sepulcrum.org> <20040617132111.GO9228@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Boundary-02=_zib0AW/AiD908xZ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Thursday 17 June 2004 15:21, Maxime Henrion wrote: > It's actually not correct. The scounters[i] here is of type u_int64_t, > so long is not the correct format here (longs are 32bit on many 32bit > architectures such as FreeBSD/i386). The correct format to use here is > %llu (long long's are at least 64bit), with a cast to (unsigned long long= ), > but most of the time we prefer to use %ju and a cast to uintmax_t. C99 > also provides macros for fixed-size type formats, and we could thus use > the PRIu64 macro here, but we don't use them because they're too ugly. > > I won't commit a fix because this code is in contrib/ and is maintained > by Max Laier (see /usr/src/MAINTAINERS). I'm CC'ing him this mail though. Thanks and sorry for the delay, really was thinking that I gave the=20 tinderboxes enough time to speak up before I went to bed. Anyway, just=20 committed a fix. For pf we use a cast to (unsigned long long) in order to=20 feed those changes back to OpenBSD (where they have no C99 and thus no=20 uintmax_t). =2D-=20 Best regards, | mlaier@freebsd.org Max Laier | ICQ #67774661 http://pf4freebsd.love2party.net/ | mlaier@EFnet --Boundary-02=_zib0AW/AiD908xZ Content-Type: application/pgp-signature Content-Description: signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQBA0bizXyyEoT62BG0RAnmFAJ9kb0tq1qwNqLLnv5Li2kbgek9rtgCdHNnb HU7K8XRQx7+HsGqlxlSUXZA= =LbQr -----END PGP SIGNATURE----- --Boundary-02=_zib0AW/AiD908xZ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200406171728.51186.max>