Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 15 Apr 2013 09:06:04 -0500
From:      Jeremy Messenger <mezz.freebsd@gmail.com>
To:        gahr@freebsd.org
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Steve Wills <steve@mouf.net>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>
Subject:   Re: svn commit: r312209 - in head/devel: allegro apr1 apr2 bennugd-core bennugd-modules boost-all boost-libs boost-python-libs bullet ccons cgit clanlib1 clanlib22 clint cocaine-core commoncpp cppcheck...
Message-ID:  <CADLFttc1JEiMPjeoF6AxBcSM4FX-LtA=6zQdSRs5q3GhX0hfkw@mail.gmail.com>
In-Reply-To: <20130415074337.GB66552@gahrfit.gahr.ch>
References:  <201302140942.r1E9gDsw053109@svn.freebsd.org> <eada70bbd61aeb921f015c0a674cd8f6.squirrel@mouf.net> <20130415074337.GB66552@gahrfit.gahr.ch>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 15, 2013 at 2:43 AM, Pietro Cerutti <gahr@freebsd.org> wrote:
> On 2013-Apr-14, 22:29, Steve Wills wrote:
>> I may be wrong, but some of these changes seem wrong. At least for glib
>> and any of the others that completely removed PTHREAD_LIBS entirely. I
>> think it's fine to replace PTHREAD_LIBS with -pthread, but removing
>> PTHREAD_LIBS or -pthread entirely could be problematic. These two PRs:
>>
>> http://www.freebsd.org/cgi/query-pr.cgi?pr=177800
>> http://www.freebsd.org/cgi/query-pr.cgi?pr=176888
>>
>> seem to be caused by this. Am I wrong? If not, we may need to go back
>> through these changes and put -pthread back where it was removed entirely.
>
> I would be surprised if they were. glib20 configures fine without the
> explicit pthread flags. See config.log. The shlib ends up correctly
> linked against the threading library:
>
>> ldd /usr/local/lib/libglib-2.0.so.0
>     libintl.so.9 => /usr/local/lib/libintl.so.9 (0x801702000)
>     libiconv.so.3 => /usr/local/lib/libiconv.so.3 (0x80190b000)
>     libpcre.so.3 => /usr/local/lib/libpcre.so.3 (0x801c04000)
>     libthr.so.3 => /lib/libthr.so.3 (0x801e67000)
>     libc.so.7 => /lib/libc.so.7 (0x80081c000)
>
> Moreover, the symptoms aren't quite what I'd expect from an application
> missing a pthread link, as they usually die in initialization phase,
> even before they reach main.

I am not able to access to FreeBSD since yesterday, but I should be
able to this afternoon. You just need to make sure the gthread's
pkg-config --libs has -pthread in it. If it does then it's probably
bug in both ports rather than glib. The update of glib, they have
rewrote thread stuff that exposed some libraries/apps bug like clutter
that has been fixed in upstream. The patch looks like:

http://www.marcuscom.com:8080/cgi-bin/cvsweb.cgi/ports/graphics/clutter/files/patch-clutter_clutter-main.c

> Moreover, if glib20 was affected, I'd expect a far larger number of
> ports to start behaving strangely ;)
>
> anyway, I'm building xpra as we speak and I'll let you know what I find
> out.
>
>
>>
>> Steve
>>
>> > Author: gahr
>> > Date: Thu Feb 14 09:42:12 2013
>> > New Revision: 312209
>> > URL: http://svnweb.freebsd.org/changeset/ports/312209
>> >
>> > Log:
>> >   - Get rid of PTHREAD_CFLAGS and PTHREAD_LIBS (category: devel)
>> >
>> >   Approved by:      portmgr
>> >
>> > Deleted:
<snip>

Next time, please do our favor by snip off very long and long diff in the email.

>
> --
> Pietro Cerutti
> The FreeBSD Project
> gahr@FreeBSD.org
>
> PGP Public Key:
> http://gahr.ch/pgp



--
mezz.freebsd@gmail.com - mezz@FreeBSD.org
FreeBSD GNOME Team
http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLFttc1JEiMPjeoF6AxBcSM4FX-LtA=6zQdSRs5q3GhX0hfkw>