From owner-freebsd-arm@FreeBSD.ORG Mon May 25 22:19:44 2015 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2102DA37; Mon, 25 May 2015 22:19:44 +0000 (UTC) (envelope-from tim@kientzle.com) Received: from monday.kientzle.com (kientzle.com [142.254.26.11]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DE418D08; Mon, 25 May 2015 22:19:43 +0000 (UTC) (envelope-from tim@kientzle.com) Received: (from root@localhost) by monday.kientzle.com (8.14.4/8.14.4) id t4PMJfAx011642; Mon, 25 May 2015 22:19:41 GMT (envelope-from tim@kientzle.com) Received: from [192.168.2.105] (192.168.1.65 [192.168.1.65]) by kientzle.com with SMTP id y4ke5f2a8f69vpaei7ksjzsef2; Mon, 25 May 2015 22:19:40 +0000 (UTC) (envelope-from tim@kientzle.com) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Subject: Re: am335x-bone.dts not exist From: Tim Kientzle In-Reply-To: <142808D5-D628-4FCF-BDF4-BBC96D91E118@bsdimp.com> Date: Mon, 25 May 2015 15:19:40 -0700 Cc: FreeBSD current , freebsd-arm , Garrett Cooper Content-Transfer-Encoding: quoted-printable Message-Id: <27DD7AA7-4B66-4A8C-A529-1D67B081326E@kientzle.com> References: <8FF14032-CAAA-41AD-A3A7-DBBAA69D2153@bluezbox.com> <4F170567-59B8-477B-8524-D15AF58288C2@kientzle.com> <142808D5-D628-4FCF-BDF4-BBC96D91E118@bsdimp.com> To: Warner Losh X-Mailer: Apple Mail (2.2098) X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 May 2015 22:19:44 -0000 > On May 25, 2015, at 8:25 AM, Warner Losh wrote: >=20 >>=20 >> On May 24, 2015, at 7:44 PM, Tim Kientzle wrote: >>=20 >>>=20 >>> On May 24, 2015, at 12:55 AM, Oleksandr Tymoshenko = wrote: >>>=20 >>>=20 >>>> On May 24, 2015, at 12:12 AM, Garrett Cooper = wrote: >>>>=20 >>>> On May 24, 2015, at 0:07, Oleksandr Tymoshenko = wrote: >>>>=20 >>>>>> On May 23, 2015, at 7:21 PM, Andrey Fesenko = wrote: >>>>>>=20 >>>>>> # uname -a >>>>>> FreeBSD des.local 11.0-CURRENT FreeBSD 11.0-CURRENT #0 r283306: = Sat >>>>>> May 23 11:56:46 MSK 2015 >>>>>> root@des.local:/usr/obj/usr/src/sys/GENERIC amd64 >>>>>>=20 >>>>>> I'm build BEAGLEBONE with crochet. >>>>>>=20 >>>>>> build error >>>>>>=20 >>>>>> Mounting UFS partition 1 at /usr/obj/_.mount.freebsd >>>>>> Installing U-Boot from : = /usr/local/share/u-boot/u-boot-beaglebone >>>>>> Error: beaglebone.dts:29.1-2 syntax error >>>>>> FATAL ERROR: Unable to parse input tree >>>>>>=20 >>>>>>=20 >>>>>> file /usr/src/sys/boot/fdt/dts/arm/beaglebone.dts contain = #include >>>>>> "am335x-bone.dts" but this file not existence. Need use = am335x-evm.dts >>>>>> or else? >>>>>=20 >>>>>=20 >>>>> am335x-bone.dts in in sys/gnu/dts/arm/, it's a file provided by = vendor (TI) >>>>>=20 >>>>> I guess crochet does not have this path as include path when = compiling >>>>> dts files. >>>>=20 >>>> Pardon me for being a bit daft potentially, but shouldn=92t = #include work for all dts files (look for #include in this doc: = http://events.linuxfoundation.org/sites/events/files/slides/petazzoni-devi= ce-tree-dummies.pdf )? >>>> Thanks! >>>>=20 >>>=20 >>>=20 >>> #include in dts file is handled by cpp(1). /include/ is handled >>> by dtc I believe >>>=20 >>> You can take a look at how FreeBSD compiles dts files in >>> sys/tools/fdt/make_dtb.sh >>>=20 >>> crochet does not have cpp stage of compilation and before my TI >>> code/devicetree refactoring none of the dts files referenced in >>> crochet used #include. That's why problem never appeared. >>>=20 >>> Fix is just a matter of fixing freebsd_install_fdt in = lib/freebsd.sh. >>> If nobody beats me to it I'll try to fix it and submit pull request = to Tim. >>=20 >> I=92m testing a fix for this now. >>=20 >> Thanks for providing such detailed information. >=20 > Is there any reason the standard dts to dtb script isn=92t being used = instead of enshrining another copy of that outside the tree which may = break if/when we need to enhance the current script? Until recently, this didn=92t seem necessary; it was a lot simpler to = just invoke dtc. But times change: https://github.com/freebsd/crochet/commit/22d7555 Tim