From owner-svn-src-head@FreeBSD.ORG Sat Aug 24 16:44:50 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 5B2C7465; Sat, 24 Aug 2013 16:44:50 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from mail0.glenbarber.us (mail0.glenbarber.us [208.86.227.67]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 2FB7127F5; Sat, 24 Aug 2013 16:44:49 +0000 (UTC) Received: from glenbarber.us (unknown [IPv6:2001:470:8:1205:99cd:72d:5e87:427e]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: gjb) by mail0.glenbarber.us (Postfix) with ESMTPSA id C74902A24; Sat, 24 Aug 2013 16:44:48 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.8.3 mail0.glenbarber.us C74902A24 Authentication-Results: mail0.glenbarber.us; dkim=none reason="no signature"; dkim-adsp=none Date: Sat, 24 Aug 2013 12:44:46 -0400 From: Glen Barber To: "Kenneth D. Merry" Subject: Re: svn commit: r254760 - in head: share/man/man4 sys/cam/scsi sys/kern sys/sys Message-ID: <20130824164446.GA41859@glenbarber.us> References: <201308240452.r7O4qMji033904@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CPaaJmjEtnx7DmsZ" Content-Disposition: inline In-Reply-To: <201308240452.r7O4qMji033904@svn.freebsd.org> X-Operating-System: FreeBSD 10.0-CURRENT amd64 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Aug 2013 16:44:50 -0000 --CPaaJmjEtnx7DmsZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 24, 2013 at 04:52:22AM +0000, Kenneth D. Merry wrote: > Author: ken > Date: Sat Aug 24 04:52:22 2013 > New Revision: 254760 > URL: http://svnweb.freebsd.org/changeset/base/254760 >=20 > [...] > @@ -83,6 +113,17 @@ physio(struct cdev *dev, struct uio *uio > */ > iolen =3D ((vm_offset_t) bp->b_data) & PAGE_MASK; > if ((bp->b_bcount + iolen) > bp->b_kvasize) { > + /* > + * This device does not want I/O to be split. > + */ > + if (dev->si_flags & SI_NOSPLIT) { > + printf("%s: request ptr %#jx is not " > + "on a page boundary, cannot split " > + "request\n", devtoname(dev), > + (uintmax_t)bp->b_data); This breaks LINT for at least powerpc. cc1: warnings being treated as errors /src/sys/kern/kern_physio.c: In function 'physio': /src/sys/kern/kern_physio.c:123: warning: cast from pointer to integer of d= ifferent size [-Wpointer-to-int-cast] *** Error code 1 http://tinderbox.freebsd.org/tinderbox-head-build-HEAD-powerpc-powerpc.full Glen --CPaaJmjEtnx7DmsZ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (FreeBSD) iQEcBAEBCAAGBQJSGOL+AAoJEFJPDDeguUajy7MIAI1S2l6dQY7IKsoYWwBrVpGx BgdgJMcbNA2vD2ZORtcwe9j9blcXrfZ3AZPWrSky4xA3qFuEA5ryndyge5t3FeQR UHXu7wK+aOM54RqvJajWawBpe3Abfvsa0NibNja8Ir9L7JCqI7QT28ss1d3P012E CZ8p/hGT5ycT4hsSzNDfuYZLxsXpWSXyDg1cK0OCbWdLCVAtDtFBlu2EB5PTIg14 GlnlHj29oPFA2tSWsD9EdYpvuJFUeSWoAkhcP1hLOetAtQYVpvj/FxbyIU9Q4v7q DJnR+1wA9eKnWDA06EM0nSVbsu9Fu253rLXiu2iTTviSFBZB8CNz/xDKoG8hotE= =8VIY -----END PGP SIGNATURE----- --CPaaJmjEtnx7DmsZ--