Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 23 May 2018 07:39:03 +0000 (UTC)
From:      Eitan Adler <eadler@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r334077 - in head/sbin/devd: . tests
Message-ID:  <201805230739.w4N7d34c062450@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: eadler
Date: Wed May 23 07:39:02 2018
New Revision: 334077
URL: https://svnweb.freebsd.org/changeset/base/334077

Log:
  devd: correct two warnings
  
  - catching a polymorphic type by value
  - "output between 16 and 95 bytes into a destination of size 80"

Modified:
  head/sbin/devd/devd.cc
  head/sbin/devd/tests/client_test.c

Modified: head/sbin/devd/devd.cc
==============================================================================
--- head/sbin/devd/devd.cc	Wed May 23 07:39:00 2018	(r334076)
+++ head/sbin/devd/devd.cc	Wed May 23 07:39:02 2018	(r334077)
@@ -1087,7 +1087,7 @@ event_loop(void)
 				try {
 					process_event(buffer);
 				}
-				catch (std::length_error e) {
+				catch (const std::length_error& e) {
 					devdlog(LOG_ERR, "Dropping event %s "
 					    "due to low memory", buffer);
 				}

Modified: head/sbin/devd/tests/client_test.c
==============================================================================
--- head/sbin/devd/tests/client_test.c	Wed May 23 07:39:00 2018	(r334076)
+++ head/sbin/devd/tests/client_test.c	Wed May 23 07:39:02 2018	(r334077)
@@ -50,7 +50,7 @@ create_two_events(void)
 	FILE *create_stdout;
 	FILE *destroy_stdout;
 	char mdname[80];
-	char destroy_cmd[80];
+	char destroy_cmd[95];
 	char *error;
 
 	create_stdout = popen("mdconfig -a -s 64 -t null", "r");



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201805230739.w4N7d34c062450>