From owner-svn-src-all@FreeBSD.ORG  Wed Jan  7 20:52:05 2015
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id D6F0C3D1;
 Wed,  7 Jan 2015 20:52:05 +0000 (UTC)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 5ED6C1DF1;
 Wed,  7 Jan 2015 20:52:05 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t07Kq3g4093193
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Wed, 7 Jan 2015 23:52:03 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t07Kq3TF093192;
 Wed, 7 Jan 2015 23:52:03 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Wed, 7 Jan 2015 23:52:03 +0300
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Luiz Otavio O Souza <loos@FreeBSD.org>
Subject: Re: svn commit: r276751 - head/sys/netinet
Message-ID: <20150107205203.GI15484@FreeBSD.org>
References: <201501061307.t06D7E0a001358@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201501061307.t06D7E0a001358@svn.freebsd.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Jan 2015 20:52:06 -0000

On Tue, Jan 06, 2015 at 01:07:14PM +0000, Luiz Otavio O Souza wrote:
L> Author: loos
L> Date: Tue Jan  6 13:07:13 2015
L> New Revision: 276751
L> URL: https://svnweb.freebsd.org/changeset/base/276751
L> 
L> Log:
L>   Remove the check that prevent carp(4) advskew to be set to '0'.
L>   
L>   CARP devices are created with advskew set to '0' and once you set it to
L>   any other value in the valid range (0..254) you can't set it back to zero.
L>   
L>   The code in question is also used to prevent that zeroed values overwrite
L>   the CARP defaults when a new CARP device is created.  Since advskew already
L>   defaults to '0' for newly created devices and the new value is guaranteed
L>   to be within the valid range, it is safe to overwrite it here.
L>   
L>   PR:		194672
L>   Reported by:	cmb@pfsense.org
L>   In collaboration with:	garga
L>   Tested by:	garga
L>   MFC after:	2 weeks

Please correct me if I am wrong, but after this change any SIOCSVH will reset
the advskew to 0.

For example, please try to:

ifconfig igb0 vhid 1 advskew 100
ifconfig igb0 vhid 1 pass foobar

Now let's check the advskew:

ifconfig igb0

-- 
Totus tuus, Glebius.