Date: Wed, 15 Jan 2014 00:24:43 +0900 From: TAKATSU Tomonari <tota@FreeBSD.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers <ports-committers@freebsd.org> Subject: Re: svn commit: r338361 - in head/devel/silentbob: . files Message-ID: <CANaE3C8g2Rf%2BrxZbrMT_h3FAMhw7Qo1qbxNvM1Q2WTDWOex2Vg@mail.gmail.com> In-Reply-To: <20140114141654.GA47381@FreeBSD.org> References: <201401010649.s016nJ4w004860@svn.freebsd.org> <20140113082949.GB8735@FreeBSD.org> <CANaE3C-Dy18HAiXhFuhiHyM7GoKPqNAHtSd4OHHwHGp_bNZb=g@mail.gmail.com> <20140114141654.GA47381@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2014/1/14 Alexey Dokuchaev <danfe@freebsd.org>:
> On Tue, Jan 14, 2014 at 10:14:19PM +0900, TAKATSU Tomonari wrote:
>> 2014/1/13 Alexey Dokuchaev <danfe@freebsd.org>:
>> Thank you for pointing out my mistakes.
>
> Thank you for taking my feedback constructively.
>
>> -.include <bsd.port.options.mk>
>> -
>
> This hunk is OK.
>
>> post-patch:
>> @${RM} ${WRKSRC}/CMakeCache.txt
>> @${REINPLACE_CMD} -e
>> 's|/usr/lib/silent_bob/|${PREFIX}/lib/silent_bob/|' \
>> ${WRKSRC}/src/init.cxx
>
> Here we have a minor problem: REINPLACE_CMD statement is a bit too long, and
> causes a line wrap. Would you consider this equivalent, but shorter version
> instead:
>
> @${REINPLACE_CMD} -e '/lib\/silent_bob/s|/usr|${PREFIX}|' \
> ${WRKSRC}/src/init.cxx
>
> It also is more vocal: for lib/silent_bob, we change /usr into ${PREFIX},
> and reduces duplication ("silent_bob" is spelled only once).
>
>> post-install:
>> @${MKDIR} ${STAGEDIR}${DOCSDIR}
>> - @${INSTALL_DATA} ${WRKSRC}/${PORTDOCS} ${STAGEDIR}${DOCSDIR}
>> -.endif
>> + ${INSTALL_DATA} ${WRKSRC}/${PORTDOCS} ${STAGEDIR}${DOCSDIR}
>
> This part is OK.
>
> ./danfe
Thank you for your advice.
I'll commit with the improvement of the REINPLACE_CMD statement.
--
TAKATSU Tomonari
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANaE3C8g2Rf%2BrxZbrMT_h3FAMhw7Qo1qbxNvM1Q2WTDWOex2Vg>