Date: Sun, 22 Aug 1999 13:30:02 -0700 (PDT) From: Tim Vanderhoek <tim@ppp18344.on.bellglobal.com> To: freebsd-bugs@FreeBSD.org Subject: Re: pending/13309: nos-tun doesn't check return values%2 Message-ID: <199908222030.NAA78971@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/13309; it has been noted by GNATS.
From: Tim Vanderhoek <tim@ppp18344.on.bellglobal.com>
To: freebsd-gnats-submit@freebsd.org, freebsd@spatula.net
Cc:
Subject: Re: pending/13309: nos-tun doesn't check return values%2
Date: Sun, 22 Aug 1999 16:23:30 -0400 (EDT)
>
>+/*
>+ * 19990727 - Nick Johnson <freebsd@spatula.net>
>+ * Added -r and -w flags, cleaned up the code a bit,
>+ * made writes more robust (return values were not being
>+ * checked)
>+ */
Don't include these type of comments. We have cvs do this for us.
>-void Finish(int signum)
>+void Cleanup()
> {
I guess there's no prototype for this function.
>+ if(Set_address(target, to))
>+ return(4);
To maintain consistency with the existing nos-tun.c, consider using
a "{ ... }" block even if it's not needed.
>-end, a concept cisco doesn't really implement.
>+end, a concept Cisco doesn't really implement. Destination may be
>+a hostname.
To make keeping the translated manpages synchronized with their
English versions easier, don't gratuitously change a line. The
sentence you added should have been started on a new line.
[Actually, there has been some suggestion that standard mdoc style is
to start sentences on newlines in most cases... You may consider this,
too... It means that future changes are clearer and easier to read ---
once again important for people doing translation.]
>-address set on the remote end.
>+address set on the remote end. Target may be a hostname.
Same.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199908222030.NAA78971>