From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Jun 27 23:10:02 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 30542CB5 for ; Thu, 27 Jun 2013 23:10:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 08CDF15CA for ; Thu, 27 Jun 2013 23:10:02 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r5RNA1fR036517 for ; Thu, 27 Jun 2013 23:10:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r5RNA1uG036516; Thu, 27 Jun 2013 23:10:01 GMT (envelope-from gnats) Date: Thu, 27 Jun 2013 23:10:01 GMT Message-Id: <201306272310.r5RNA1uG036516@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org Cc: From: "Jens K. Loewe" Subject: Re: ports/177733: [maintainer update] graphics/nomacs update to version 1.0.2 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: "Jens K. Loewe" List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jun 2013 23:10:02 -0000 The following reply was made to PR ports/177733; it has been noted by GNATS. From: "Jens K. Loewe" To: bug-followup@FreeBSD.org, bsd@tuxproject.de Cc: Subject: Re: ports/177733: [maintainer update] graphics/nomacs update to version 1.0.2 Date: Fri, 28 Jun 2013 00:57:19 +0200 Well, yes, you're right. (Also, meanwhile they updated to nomacs 1.2.0.) Not sure whether to submit a new PR or not. Well, I just updated the port and tried building it with and without RAW support. That said, here's the updated patch, hope I got it right this time: diff -ruN alt/Makefile neu-with-options/Makefile --- alt/Makefile 2013-03-01 21:11:05.000000000 +0100 +++ neu-with-options/Makefile 2013-06-28 00:49:24.000000000 +0200 @@ -1,10 +1,10 @@ # $FreeBSD$ PORTNAME= nomacs -PORTVERSION= 1.0.0 +PORTVERSION= 1.2.0 CATEGORIES= graphics MASTER_SITES= SF/nomacs/nomacs-${PORTVERSION}/ -DISTNAME= ${PORTNAME}-${PORTVERSION} +DISTNAME= ${PORTNAME}-${PORTVERSION}-source MAINTAINER= bsd@tuxproject.de COMMENT= Small, fast and free image viewer @@ -14,6 +14,10 @@ LIB_DEPENDS= exiv2:${PORTSDIR}/graphics/exiv2 \ sysinfo:${PORTSDIR}/devel/libsysinfo +OPTIONS_DEFINE= RAW +OPTIONS_DEFAULT= ${OPTIONS_DEFINE} +RAW_DESC= Enable RAW support + USE_BZIP2= yes USE_CMAKE= yes USE_QT4= gui network linguist_build moc_build \ @@ -22,6 +26,14 @@ WRKTOP= ${WRKDIR} WRKSUBDIR= ${PORTNAME}-${PORTVERSION} WRKSRC= ${WRKTOP}/${WRKSUBDIR} -CMAKE_ARGS+= -DENABLE_RAW=0 + +.include + +.if ${PORT_OPTIONS:MRAW} +LIB_DEPENDS+=raw:${PORTSDIR}/graphics/libraw \ + opencv:${PORTSDIR}/graphics/opencv +.else +CMAKE_ARGS+=-DENABLE_RAW=0 +.endif .include diff -ruN alt/distinfo neu-with-options/distinfo --- alt/distinfo 2013-03-01 20:10:21.000000000 +0100 +++ neu-with-options/distinfo 2013-06-28 00:48:23.000000000 +0200 @@ -1,2 +1,2 @@ -SHA256 (nomacs-1.0.0.tar.bz2) = bf2a0a9ecb35551dc8ed25c0db95c1183b3771a2ce9e2a41d7e1d230bac2c5f2 -SIZE (nomacs-1.0.0.tar.bz2) = 803404 +SHA256 (nomacs-1.2.0-source.tar.bz2) = 0c60e5d17a7f3d17f33344b59440dad2bac0358fd1fae85b48574f2c61674259 +SIZE (nomacs-1.2.0-source.tar.bz2) = 859335