From owner-svn-src-all@freebsd.org Tue Apr 30 14:26:49 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 51DCA15933BC; Tue, 30 Apr 2019 14:26:49 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-it1-x136.google.com (mail-it1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E043B73C66; Tue, 30 Apr 2019 14:26:48 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-it1-x136.google.com with SMTP id q14so4981561itk.0; Tue, 30 Apr 2019 07:26:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=AWfwmAgJHxypDflhfBcVHSclA2QkjF7Sfhx13+hiZ4Y=; b=YgVJWdgjT2LR+RzCQXNYuSER6Q5ea+1bSRm3P5gi+bO8qSTW7LUV/XOpBjE3yJpZWx MEL/HtIGbgCu1spw29tqkKLt8UQS63A9OjA2wAsMElAS5a3krEqlw+YYar3zVKbv1ACo J2LKdnhfg4RzWMsSxu6lIMNOTrYl9+mH85GO5Q1mxUuEaOcZfTNmJQgyyKO48e5TF6C3 HGBnWk2H3u8DczyNCYQ0n4+6iq0xp8EJz/+xTjnLTpzc69hbph/djxAmDD3zis+vdE4U MGgdUQfiiFGKVHON4Kf372lEXaRNDBaHKwTaoXCc9wGEpRVjSNHOWkgu0niRWEt2vu1D NNng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=AWfwmAgJHxypDflhfBcVHSclA2QkjF7Sfhx13+hiZ4Y=; b=A6nQjwVEuEqW1nnguprIya/NuiJM+ckbSgjXFHwWHj0zX50gv6JPZnGOlPh2RtlbLU 5neDqeDgBO9pyl2Xt8IKUWiJG8I9yy3kfxu6EY4FA5BPHC0+dw1NHFyft//mEEPcgWHP WTguoUngPNvkxS8UxAGTIicrZcBq3564uzNVmtEEJt4vKfNSEiA6vuJO/it+UJU1wxlU v3BT16AmsuNnsnPeSY+DzZkVnQZCcjHcnTqwLYYpx21YpQsl2cLHOkaUu0CV7q34quHr o+kE7s3g4pHHXdJ+stsXnpAp9k9mwm43wpYSLssWJr+8ypz+jDxOZgonXodhzhTIXFTL /Rqg== X-Gm-Message-State: APjAAAVCG69Ap4JP8+SK1VZ5r4CgFce4C67SaxwLiG2aVoGwnwvIbUdt h0VmWYyGj6Re5IFs05yGpHFKR5IDfU8= X-Google-Smtp-Source: APXvYqyEiKq3UPiVWtkEZFNkI+MV5WhuxaPGXC2BcrMlIw8cYIK85cfaQ44RczfmAaz9x8GB9g65vg== X-Received: by 2002:a02:cc8d:: with SMTP id s13mr1947927jap.115.1556634407790; Tue, 30 Apr 2019 07:26:47 -0700 (PDT) Received: from raichu (toroon0560w-lp140-01-69-159-36-31.dsl.bell.ca. [69.159.36.31]) by smtp.gmail.com with ESMTPSA id s15sm2733951iob.70.2019.04.30.07.26.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 30 Apr 2019 07:26:46 -0700 (PDT) Sender: Mark Johnston Date: Tue, 30 Apr 2019 10:26:41 -0400 From: Mark Johnston To: Alexey Dokuchaev Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r346932 - head/sys/ufs/ufs Message-ID: <20190430142641.GA34567@raichu> References: <201904292205.x3TM5Q7Z058461@repo.freebsd.org> <20190430060849.GB97846@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190430060849.GB97846@FreeBSD.org> User-Agent: Mutt/1.11.4 (2019-03-13) X-Rspamd-Queue-Id: E043B73C66 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.990,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Apr 2019 14:26:49 -0000 On Tue, Apr 30, 2019 at 06:08:49AM +0000, Alexey Dokuchaev wrote: > On Mon, Apr 29, 2019 at 10:05:26PM +0000, Mark Johnston wrote: > > New Revision: 346932 > > URL: https://svnweb.freebsd.org/changeset/base/346932 > > > > Log: > > Optimize lseek(SEEK_DATA) on UFS. > > > > This version fixes the problems identified in r345244. > > > > Reviewed by: kib > > @@ -56,6 +56,9 @@ __FBSDID("$FreeBSD$"); > > #include > > #include > > > > +static ufs_lbn_t lbn_count(struct ufsmount *, int); > > +static int readindir(struct vnode *, ufs_lbn_t, ufs2_daddr_t, struct buf **); > > Is the prototype for static readindir() really needed here? Yes, when using a K&R definition. > > +static int > > +readindir(vp, lbn, daddr, bpp) > > + struct vnode *vp; > > + ufs_lbn_t lbn; > > + ufs2_daddr_t daddr; > > + struct buf **bpp; > > Don't we prefer ASNI declarations over K&R these days? Yes, I was just staying consistent with the rest of the file. > > +static ufs_lbn_t > > +lbn_count(ump, level) > > + struct ufsmount *ump; > > + int level; > > Ditto. > > > +int > > +ufs_bmap_seekdata(vp, offp) > > + struct vnode *vp; > > + off_t *offp; > > ./danfe