From owner-cvs-all@FreeBSD.ORG Thu Aug 5 03:32:21 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AE34C16A4CE; Thu, 5 Aug 2004 03:32:21 +0000 (GMT) Received: from mx.nsu.ru (mx.nsu.ru [212.192.164.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id 20CB643D5D; Thu, 5 Aug 2004 03:32:20 +0000 (GMT) (envelope-from danfe@regency.nsu.ru) Received: from regency.nsu.ru ([193.124.210.26]) by mx.nsu.ru with esmtp (Exim 4.32) id 1BsZ8s-0006QJ-9H; Thu, 05 Aug 2004 10:42:10 +0700 Received: from regency.nsu.ru (localhost [127.0.0.1]) by regency.nsu.ru (8.12.10/8.12.10) with ESMTP id i753ZY9k015605; Thu, 5 Aug 2004 10:35:34 +0700 (NOVST) (envelope-from danfe@regency.nsu.ru) Received: (from danfe@localhost) by regency.nsu.ru (8.12.10/8.12.10/Submit) id i753ZY6p015555; Thu, 5 Aug 2004 10:35:34 +0700 (NOVST) (envelope-from danfe) Date: Thu, 5 Aug 2004 10:35:34 +0700 From: Alexey Dokuchaev To: Tim Robbins , Garance A Drosehn , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-ID: <20040805033534.GA11375@regency.nsu.ru> References: <200408012045.i71KjtFX087582@repoman.freebsd.org> <20040802034509.GB81089@regency.nsu.ru> <20040802042750.GA24962@cat.robbins.dropbear.id.au> <20040804210524.GA8512@VARK.homeunix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040804210524.GA8512@VARK.homeunix.com> User-Agent: Mutt/1.4.2.1i Subject: Re: cvs commit: src/usr.bin/patch - Imported sources X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Aug 2004 03:32:21 -0000 On Wed, Aug 04, 2004 at 02:05:24PM -0700, David Schultz wrote: > On Mon, Aug 02, 2004, Tim Robbins wrote: > > On Mon, Aug 02, 2004 at 10:45:09AM +0700, Alexey Dokuchaev wrote: > > > On Sun, Aug 01, 2004 at 08:45:55PM +0000, Garance A Drosehn wrote: > > > > gad 2004-08-01 20:45:55 UTC > > > > > > > > FreeBSD src repository > > > > > > > > src/usr.bin/patch - Imported sources > > > > Update of /home/ncvs/src/usr.bin/patch > > > > In directory repoman.freebsd.org:/tmp/cvs-serv87568 > > > > > > > > Log Message: > > > > Import of a BSD-licensed version of `patch', which will eventually > > > > replace the version we currently have in src/gnu/usr.bin/patch/. > > > > Among other things, this version includes a --posix option for strict > > > > POSIX conformance. > > > > > > > > This version is the current source from OpenBSD as of today. It is > > > > their 3.5-release, plus a few updates to patch.c and pch.c that they > > > > made about three weeks ago. > > > > > > May I ask why you preferred OpenBSD's version over NetBSD's? It was > > > shown in the past that OpenBSD's way of doing thing is a bit rough on > > > the edges sometimes (humanize_number(3) vs. fmt_scaled(3) and > > > scan_scaled(3), ftw(3) and nftw(3), etc). > > > > Actually, OpenBSD's ftw()/nftw() implementation is better than the one > > we recently imported, in terms of both style and functionality; I wish we'd > > gone with it instead. What we have in -CURRENT at the moment is incredibly > > buggy for such a simple function. The droll, inane comments ("Because > > errno is our friend") and style violations only make things worse. > > I agree about the style. What's wrong with the functionality? > > I have no objection to switching to Todd's (much cleaner) [n]ftw() > implementation, although I'm not aware of any non-stylistic > problems with the current code. I also recall you (David) mentioning that current implementation does the same thing in half the lines of code, despite its style(9) deficiencies, and that was the reason why it was imported instead of OpenBSD's one. Now when Tim says OpenBSD's one is functionally ahead, I wonder what is better: to improve our (current) version WRT both style and functionality, probably without doubling the code lines, or make a step backwards and import OpenBSD version? ./danfe