Date: Wed, 13 Jun 2018 20:10:22 -0400 From: Allan Jude <allanjude@freebsd.org> To: Eitan Adler <eadler@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334514 - head/usr.bin/top Message-ID: <b03b8a00-e14d-b670-e5b7-b105a9eb5d2a@freebsd.org> In-Reply-To: <201806020325.w523PFKn048824@repo.freebsd.org> References: <201806020325.w523PFKn048824@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7DDuQYUGSbTUQv3pZxcbJnPTCYamvHSzk Content-Type: multipart/mixed; boundary="w44D7cW2St8qhBuBFNNPMF4JBwypg9H0Q"; protected-headers="v1" From: Allan Jude <allanjude@freebsd.org> To: Eitan Adler <eadler@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <b03b8a00-e14d-b670-e5b7-b105a9eb5d2a@freebsd.org> Subject: Re: svn commit: r334514 - head/usr.bin/top References: <201806020325.w523PFKn048824@repo.freebsd.org> In-Reply-To: <201806020325.w523PFKn048824@repo.freebsd.org> --w44D7cW2St8qhBuBFNNPMF4JBwypg9H0Q Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2018-06-01 23:25, Eitan Adler wrote: > Author: eadler > Date: Sat Jun 2 03:25:15 2018 > New Revision: 334514 > URL: https://svnweb.freebsd.org/changeset/base/334514 >=20 > Log: > top(1): Use standard boolean rather than homegrown alternative >=20 > Deleted: > head/usr.bin/top/boolean.h > Modified: > head/usr.bin/top/commands.c > head/usr.bin/top/display.c > head/usr.bin/top/machine.c > head/usr.bin/top/screen.c > head/usr.bin/top/top.1 > head/usr.bin/top/top.c >=20 > Modified: head/usr.bin/top/machine.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/usr.bin/top/machine.c Sat Jun 2 02:06:48 2018 (r334513) > +++ head/usr.bin/top/machine.c Sat Jun 2 03:25:15 2018 (r334514) > @@ -35,6 +35,7 @@ > #include <paths.h> > #include <pwd.h> > #include <stdio.h> > +#include <stdbool.h> > #include <stdlib.h> > #include <string.h> > #include <strings.h> > @@ -308,7 +309,7 @@ machine_init(struct statics *statics) > { > int i, j, empty, pagesize; > uint64_t arc_size; > - boolean_t carc_en; > + bool carc_en; > size_t size; > =20 > size =3D sizeof(smpmode); >=20 This broke compressed ARC display in top. The sysctl vfs.zfs.compressed_arc_enabled is backed by a boolean_t (which is the same size as an int), so trying to read it into a bool (1 byte) fails and returns ENOMEM. Fixed in r335099 --=20 Allan Jude --w44D7cW2St8qhBuBFNNPMF4JBwypg9H0Q-- --7DDuQYUGSbTUQv3pZxcbJnPTCYamvHSzk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) iQIcBAEBAgAGBQJbIbJzAAoJEBmVNT4SmAt+kRgQAOFafGeBHKj2ouHnUSJBlGIc yKHIrBWKL2UhyoK0vt7Xyt4xFjnkPN2dPHwNQx+Y/UMKqG6hz9+W4apRNvGKsZAw +Vmu/AFO4uOL3z3HJw7CjbGdcHAcbz6CUrqavsMUP14YliMG0BlsbjEFwtHkU+s9 pif3o1mSTxURdXU3ur/6T5cuCNcZz6yoVmhmOjRS3Cta0UkYTtv56ewpiMy0HuMW kJDAWnHaLDrzW1lrifHG6Gp76wAB8GDKhFO7sK6An+b6lnjMY5j+Oty3NxRjuUcA 6BE5N6Uz5/BocWspVlcvAcGlQyd/4JqyCWRcgD0pORNVJJjENpTPHs3LcFEWUcsC nx/wX/V43YkL44aRi2XywrFzhVWw8agDnxwlFfb/3IlUdk7Rm65syp8cCTTWBzOZ 5A2UWdAYM82HErJZkcYRxjK1xk2jMmNIf/5Rh56H4TK/MOjT6g7fr7Y8boWsLj2+ EuS5PiDnv6x6b4WKXiwVH28CGuIaKIDxLCD+2+GnZS7weVwVIQqtYJzJw7MvjRMu uQ4hJzjbGbSK7CffdSHSdr0qkeUCSo9o0aDH7a1n0UBihn9K8ptr0vJjvBcberUL RKZIA8Xx9pQskXn8aMXqBMw9SfUmyAG4uGzsywhIE4TFtxywKF3nWWlENShZFzn7 5k+kVFQpNB6HZ34TAY3a =NpQJ -----END PGP SIGNATURE----- --7DDuQYUGSbTUQv3pZxcbJnPTCYamvHSzk--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b03b8a00-e14d-b670-e5b7-b105a9eb5d2a>