From owner-svn-src-all@freebsd.org Wed Dec 7 05:35:42 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3E8CFC6BA20; Wed, 7 Dec 2016 05:35:42 +0000 (UTC) (envelope-from melounmichal@gmail.com) Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C6255920; Wed, 7 Dec 2016 05:35:41 +0000 (UTC) (envelope-from melounmichal@gmail.com) Received: by mail-wm0-x243.google.com with SMTP id g23so25613186wme.1; Tue, 06 Dec 2016 21:35:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:reply-to:subject:references:to:cc:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=N1AS75b96Blx9XqF+7TWQ237lQgtfMtXJr/qQR6eqy0=; b=HbdG7RAe2E1Hwm1mFAva3XWi3AorvkKFTXz4X1WkR0y44zoKi+wGr6uzv1qw5S7Jqc 5QgbuAmh5jheKzJDl2U5b7ZOKSDMY1cYBWD/+2c9sPF6tenBFgEO6IpNZKawjZevuOPW CDmGn0xhZ8XFwgVr656kNgWgnMQhjdZowlY2zgkRkr3NptPTJo9j1K8zJzfMKWaPUAWJ UdZBRVG+sUHdsDfpSkr7m0ES9tsX7YCz31a5BWaMGVkT4zB3iW4iXMZfhZ9KY3wjl40n EsAx6VeQjU7ZxMPv2ggLouAmuOud5ev5zjTVw5QCOGJhnT3s6f/CZv6Cq2/gBG4JdNH4 jr5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:reply-to:subject:references:to:cc :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding; bh=N1AS75b96Blx9XqF+7TWQ237lQgtfMtXJr/qQR6eqy0=; b=Chr398oxdGj9mAnuUPsihKPrHWU0syTg95G9mgZLaPmR0k6hz7zvHpqkjmPx/wu+SX /kq4rkDjxHn0HgR25rdPsa37R1jyUW5JFJ7VIRyXgk5I0Hl8shntqLnaiym4uVensl6U lOxfx4Vey4AAuVTodNUqW0ADFJD+TxeyIPvp/XJxqRwJe2gGGv6Q5RjfegrttyFP0E+F udxVoepU7uZ1L6OkTru56pLkD2GNG2g5V1O75vIW6UIW7W/VB+uaOXmu79PJrQgcbT/z LASBbwuT0WoucBJlkqSkJPQHF/YTyqAb2yo706ZXOM71m0Y455bj8Vbca7fD0MBdHi+5 3wdQ== X-Gm-Message-State: AKaTC01s/MCzSzPcxysMJDa1d/gXtEoXE8ioJ/LHlZztdMNb+gbfFW6JdOlGWDpGq+l0tQ== X-Received: by 10.28.69.130 with SMTP id l2mr817719wmi.123.1481088939410; Tue, 06 Dec 2016 21:35:39 -0800 (PST) Received: from [88.208.79.100] (halouny.humusoft.cz. [88.208.79.100]) by smtp.gmail.com with ESMTPSA id u81sm7550319wmu.10.2016.12.06.21.35.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Dec 2016 21:35:38 -0800 (PST) From: Michal Meloun X-Google-Original-From: Michal Meloun Reply-To: mmel@freebsd.org Subject: Re: svn commit: r309531 - head/sys/arm/include References: <201612041527.uB4FRduc064051@repo.freebsd.org> <1802951.O895X1uuQH@ralph.baldwin.cx> To: John Baldwin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <7ed22afe-65de-f6b0-22fe-7c34e2663694@freebsd.org> Date: Wed, 7 Dec 2016 06:35:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1802951.O895X1uuQH@ralph.baldwin.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2016 05:35:42 -0000 Because I'm stupid enough to not remember that we have code which is compiled only as module. So my standard 'make buildkernel -DNO_CLEAN -DNO_MODULES' is not a best option how to test this new code. And rest is only natural result of panic caused by 'I break a kernel build' and 'I have scheduled a meeting @work at now'. You are right of course, I will fix it later today. Michal On 06.12.2016 23:01, John Baldwin wrote: > On Sunday, December 04, 2016 03:27:39 PM Michal Meloun wrote: >> Author: mmel >> Date: Sun Dec 4 15:27:39 2016 >> New Revision: 309531 >> URL: https://svnweb.freebsd.org/changeset/base/309531 >> >> Log: >> Implement fake pmap_mapdev_attr() for ARMv6. >> This function is referenced, but never called from DRM2 code. Also, >> real behavior of pmap_mapdev_attr() in ARM world is unclear as we don't >> have any additional attribute for a device memory type. >> >> MFC after: 2 weeks > One more question: why not define this in pmap.c instead of an inline > function in the header file? (The inline bit seemed to have led to several > followups due to build breakage and the "fixes" require a fair bit of header > pollution.) >