Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 23 Jul 2010 14:29:47 -0500
From:      Alan Cox <alc@cs.rice.edu>
To:        Kostik Belousov <kostikbel@gmail.com>
Cc:        Alan Cox <alc@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r210429 - in head/sys: amd64/linux32 compat/freebsd32 kern sys
Message-ID:  <4C49EDAB.5020204@cs.rice.edu>
In-Reply-To: <20100723191808.GV2381@deviant.kiev.zoral.com.ua>
References:  <201007231858.o6NIwRR3087236@svn.freebsd.org> <20100723191808.GV2381@deviant.kiev.zoral.com.ua>

next in thread | previous in thread | raw e-mail | index | archive | help
Kostik Belousov wrote:
> On Fri, Jul 23, 2010 at 06:58:27PM +0000, Alan Cox wrote:
>   
>> Author: alc
>> Date: Fri Jul 23 18:58:27 2010
>> New Revision: 210429
>> URL: http://svn.freebsd.org/changeset/base/210429
>>
>> Log:
>>   Eliminate a little bit of duplicated code.
>>
>>     
> I think that amd64 copy of linux_exec_copyin_args() can go out as well.
> COMPAT_LINUX32 or linux.ko requires COMPAT_FREEBSD32, and the function
> seems to be identical to freebsd32_exec_copyin_args(), except there is
> missed check for fname != NULL.
>   

Do you want to delete it?  I would be happy for it to go away.

The reason that I was looking at this is that I'm tinkering with how we 
allocate memory for the exec strings because it accounts for > 2/3 of 
our system-wide TLB shootdowns in some workloads.




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C49EDAB.5020204>