Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 20 Dec 2010 10:39:34 +0300
From:      Anonymous <swell.k@gmail.com>
To:        "David E. O'Brien" <obrien@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r212770 - head/usr.bin/script
Message-ID:  <86sjxsq4eh.fsf@gmail.com>
In-Reply-To: <201009162231.o8GMV3Ov009118__30279.1559639902$1284676285$gmane$org@svn.freebsd.org> (David E. O'Brien's message of "Thu, 16 Sep 2010 22:31:03 %2B0000 (UTC)")
References:  <201009162231.o8GMV3Ov009118__30279.1559639902$1284676285$gmane$org@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
"David E. O'Brien" <obrien@FreeBSD.org> writes:

> Author: obrien
> Date: Thu Sep 16 22:31:03 2010
> New Revision: 212770
> URL: http://svn.freebsd.org/changeset/base/212770
>
> Log:
>   + Add the 'command' argument (if supplied on the command line) to the
>   typescript file.  This creates a more complete typescript when invoked
>   this way - more equal to invoking script without supplying the 'command'
>   argument.
[...]
> +	if (av[0])
> +		for (k = 0 ; av[k] ; ++k)
> +			fprintf(fscript, "%s%s", k ? " " : "", av[k]);
> +		fprintf(fscript, "\r\n");
> +

Can you make it opt-in? It breaks scripts that do not expect anything
other than command output in a typescript. For example, timestamps can
be disabled by `-q' option. Which make below syntax

  script -q file command ...

another way to write

  command >file 2>&1

but it captures output sent to /dev/tty, too.

Besides, the commit also breaks bin/114465, a replay feature from NetBSD.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86sjxsq4eh.fsf>