From owner-svn-src-head@FreeBSD.ORG  Mon Dec 20 07:39:41 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 71C3D106566C;
	Mon, 20 Dec 2010 07:39:41 +0000 (UTC)
	(envelope-from swell.k@gmail.com)
Received: from mail-yx0-f196.google.com (mail-yx0-f196.google.com
	[209.85.213.196])
	by mx1.freebsd.org (Postfix) with ESMTP id 00A878FC14;
	Mon, 20 Dec 2010 07:39:40 +0000 (UTC)
Received: by yxf34 with SMTP id 34so962062yxf.7
	for <multiple recipients>; Sun, 19 Dec 2010 23:39:40 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:received:received:from:to:cc:subject:references
	:date:in-reply-to:message-id:user-agent:mime-version:content-type;
	bh=Wrtra7mhK/PzuTZLZPmq3/QmN2R49FaR1cA15BWpBGA=;
	b=ncCrBrQZcixwNmtyh6KEgk2vGwnNbRiXMshZmdgx56jTr0i/pGLDkW2BRONf9Evg86
	8sy14DSc1owfz5JE8mI61bYom2ojPfvKGKZishQEIrjb7B6eWkvlO6aENqNnr04zqhvN
	ZDlYwL1r3RE95ZbFYe0P7bGVlM1UpRcZlVkaw=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=from:to:cc:subject:references:date:in-reply-to:message-id
	:user-agent:mime-version:content-type;
	b=qmVyWUsQTTfE4lLatZbI1sf2dVR4XDBzIQUOzLTuGt36PWfIgJtF4UsACRTWL0Zccn
	bxunwgub6qNn9uQ7XgExZVbmOETTSZVkxtND0lv7BhRr81jltlYvORNeCFlId0J/QvhJ
	YYKoVnOHLt/6FBqgwTK4GAsAI8rIJAuXJ1vTM=
Received: by 10.90.82.16 with SMTP id f16mr5097482agb.67.1292830780132;
	Sun, 19 Dec 2010 23:39:40 -0800 (PST)
Received: from localhost ([199.48.147.45])
	by mx.google.com with ESMTPS id e24sm8014917ana.22.2010.12.19.23.39.38
	(version=SSLv3 cipher=RC4-MD5); Sun, 19 Dec 2010 23:39:39 -0800 (PST)
From: Anonymous <swell.k@gmail.com>
To: "David E. O'Brien" <obrien@FreeBSD.org>
References: <201009162231.o8GMV3Ov009118__30279.1559639902$1284676285$gmane$org@svn.freebsd.org>
Date: Mon, 20 Dec 2010 10:39:34 +0300
In-Reply-To: <201009162231.o8GMV3Ov009118__30279.1559639902$1284676285$gmane$org@svn.freebsd.org>
	(David E. O'Brien's message of "Thu, 16 Sep 2010 22:31:03 +0000
	(UTC)")
Message-ID: <86sjxsq4eh.fsf@gmail.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r212770 - head/usr.bin/script
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Dec 2010 07:39:41 -0000

"David E. O'Brien" <obrien@FreeBSD.org> writes:

> Author: obrien
> Date: Thu Sep 16 22:31:03 2010
> New Revision: 212770
> URL: http://svn.freebsd.org/changeset/base/212770
>
> Log:
>   + Add the 'command' argument (if supplied on the command line) to the
>   typescript file.  This creates a more complete typescript when invoked
>   this way - more equal to invoking script without supplying the 'command'
>   argument.
[...]
> +	if (av[0])
> +		for (k = 0 ; av[k] ; ++k)
> +			fprintf(fscript, "%s%s", k ? " " : "", av[k]);
> +		fprintf(fscript, "\r\n");
> +

Can you make it opt-in? It breaks scripts that do not expect anything
other than command output in a typescript. For example, timestamps can
be disabled by `-q' option. Which make below syntax

  script -q file command ...

another way to write

  command >file 2>&1

but it captures output sent to /dev/tty, too.

Besides, the commit also breaks bin/114465, a replay feature from NetBSD.