Date: Thu, 10 Apr 2008 23:15:31 -0700 From: Marcel Moolenaar <xcllnt@mac.com> To: Jeff Roberson <jroberson@jroberson.net> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/amd64/amd64 intr_machdep.c src/sys/arm/arm intr.c src/sys/i386/i386 intr_machdep.c src/sys/ia64/ia64 interrupt.c src/sys/kern kern_cpuset.c kern_intr.c src/sys/powerpc/powerpc intr_machdep.c src/sys/sparc64/sparc64 ... Message-ID: <9B8DD956-E197-4540-A7F3-367B1E277456@mac.com> In-Reply-To: <20080410190028.U43186@desktop> References: <200804110326.m3B3QfjL095474@repoman.freebsd.org> <AF694C84-E229-4640-87F6-CB03C44F741C@mac.com> <20080410190028.U43186@desktop>
next in thread | previous in thread | raw e-mail | index | archive | help
On Apr 10, 2008, at 10:01 PM, Jeff Roberson wrote: > On Thu, 10 Apr 2008, Marcel Moolenaar wrote: > >> >> On Apr 10, 2008, at 8:26 PM, Jeff Roberson wrote: >>> jeff 2008-04-11 03:26:41 UTC >>> FreeBSD src repository >>> Modified files: >>> sys/amd64/amd64 intr_machdep.c >>> sys/arm/arm intr.c >>> sys/i386/i386 intr_machdep.c >>> sys/ia64/ia64 interrupt.c >>> sys/kern kern_cpuset.c kern_intr.c >>> sys/powerpc/powerpc intr_machdep.c >>> sys/sparc64/sparc64 intr_machdep.c >>> sys/sun4v/sun4v intr_machdep.c >>> sys/sys cpuset.h interrupt.h >>> Log: >>> - Add the interrupt vector number to intr_event_create so MI code >>> can >>> lookup hard interrupt events by number. Ignore the irq# for >>> soft intrs. >> >> JFYI: vectors are not the same as hard interrupt numbers. >> On ia64 they imply priority, which means that vector >> numbers should be selected for their priority and not >> have a 1-to-1 mapping with IRQ number. >> On powerpc they mean absolutely nothing other than being >> an index into an array. >> >> It's better to use IRQs and not vectors to lookup int. >> events by number. > > I think I mixed my terminology in the commit. I meant for all > architectures to pass in the number that would appear in vmstat -i. > Can you verify that this is what I did for powerpc and ia64? powerpc correctly uses irq. ia64 incorrectly uses vector. Would you mind changing ia64 to use irq as well? Thanks, -- Marcel Moolenaar xcllnt@mac.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9B8DD956-E197-4540-A7F3-367B1E277456>