From owner-freebsd-net Sat Jul 29 13:54:33 2000 Delivered-To: freebsd-net@freebsd.org Received: from falla.videotron.net (falla.videotron.net [205.151.222.106]) by hub.freebsd.org (Postfix) with ESMTP id B548C37B51B for ; Sat, 29 Jul 2000 13:54:24 -0700 (PDT) (envelope-from bmilekic@dsuper.net) Received: from modemcable009.62-201-24.mtl.mc.videotron.net ([24.201.62.9]) by falla.videotron.net (Sun Internet Mail Server sims.3.5.1999.12.14.10.29.p8) with ESMTP id <0FYH009Z78QDEF@falla.videotron.net> for net@FreeBSD.ORG; Sat, 29 Jul 2000 16:54:13 -0400 (EDT) Date: Sat, 29 Jul 2000 16:56:49 -0400 (EDT) From: Bosko Milekic Subject: Re: Mbuf stuff. In-reply-to: <200007292048.aa16087@salmon.maths.tcd.ie> X-Sender: bmilekic@jehovah.technokratis.com To: David Malone Cc: Alfred Perlstein , net@FreeBSD.ORG Message-id: MIME-version: 1.0 Content-type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Sat, 29 Jul 2000, David Malone wrote: > Do you want to commit the slip abuse stuff with it, or should I do > that now? I've been testing it and it works fine. I've started > testing the mbuf external reference counting patches and they seem > to work. I've read through them and have a few comments, but other > than that they seem fine. It should deffinately go in either before or at the same time, if you want to avoid breaking the build. > David. > > /usr/src/sys/alpha/alpha/machdep.c > > When calculating mb_map_size it doesn't add space for > sizeof (union mext_refcnt) Rats! Nice thing you caught it! Yes, it should deffinately be added to match i386/i386/machdep.c -- Thanks! > /usr/src/sys/kern/uipc_mbuf.c > > The mbstat sysctl stuff is made read only. This seems > sensible, as it doesn't make sense to write to I guess. Yes, I always wondered why it was read+write in the first place, so I changed it here instead of submitting separate diffs. > /usr/src/sys/netkey/key_debug.c > > Should we consider printing the pointer to the ref_cnt pointer? Sounds good. > /usr/src/sys/pc98/i386/machdep.c > > Same as alpha - mb_map_size doesn't account for mext_refcnt. Yeah, missed it here too. > /usr/src/sys/sys/mbuf.h > > The call to _MEXTFREE in MFREE is wrapped in braces, which > I think goes against style(9). That's up to you, it makes no difference to me. I don't remember seeing anything specifically _against_ it in style(9) but I'm not sure. > Should we comment the fact that _MEXTFREE has to be called > at splimp? Not really necessary, because it always is called at splimp(), and it's not the exported macro. The "exported" version of the macro wraps _MEXTFREE at MBUFLOCK(), and it's called MEXTFREE(). > /usr/src/usr.bin/netstat/mbuf.c > > The printf refers to "reference count structs" - should that be > "reference count unions" or maybe just "reference counters" incase > the way they are counted changes. Yes, certainly, up to you as to how you want to go with verbosity, I was just too busy thinking about related code functionality as opposed to verbosity and user-friendliness. Thank you very much for bringing all this stuff up! -Bosko -- Bosko Milekic * Voice/Mobile: 514.865.7738 * Pager: 514.921.0237 bmilekic@technokratis.com * http://www.technokratis.com/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message