From owner-freebsd-current@FreeBSD.ORG Wed Apr 20 00:17:44 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C4F97106566C for ; Wed, 20 Apr 2011 00:17:44 +0000 (UTC) (envelope-from jhellenthal@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 76AA08FC0A for ; Wed, 20 Apr 2011 00:17:44 +0000 (UTC) Received: by iwn33 with SMTP id 33so245002iwn.13 for ; Tue, 19 Apr 2011 17:17:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:date:from:to:subject:message-id :references:mime-version:content-type:content-disposition :in-reply-to:x-openpgp-key-id:x-openpgp-key-fingerprint :x-openpgp-key-url; bh=EIpaFhbg1PrEij63+al4nAwoM4eD64xzmHHEF7QgBS0=; b=E32q0NPFlxlf0daxw+spXSmLuLLEPgZZdPsaKx6eC6RXd9BcVhkcjLQrPX3bN8iBRm 7n2JBOSjSOqQb3VXK4Kc6ojMthnuoRRTn8A2Czn5teWIJDy1MO3FC/4v8PJ3pbzJ18Rz Z86s6M712Lq/TCORTy+4UVqheJXx8KX8WSEFE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:x-openpgp-key-id :x-openpgp-key-fingerprint:x-openpgp-key-url; b=Vzy+ygscSPr5swOuJY9TW7ywKBdvsjHhYng4iFts5LGakrrv6QkMj/TohlFE0uCmbO peUTdWG2bCh95TMvBedd2AgAi6gWH0YkipLbpgZwz0rCPbynkEwhveri/u3e+LTUgKmI Vpult8DeOXkBY+LjDY6OOs3ZN4uo/58CVxfEw= Received: by 10.231.25.157 with SMTP id z29mr1497413ibb.129.1303258663775; Tue, 19 Apr 2011 17:17:43 -0700 (PDT) Received: from DataIX.net (adsl-99-190-84-116.dsl.klmzmi.sbcglobal.net [99.190.84.116]) by mx.google.com with ESMTPS id d9sm141282ibb.19.2011.04.19.17.17.41 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 19 Apr 2011 17:17:42 -0700 (PDT) Sender: "J. Hellenthal" Received: from DataIX.net (localhost [127.0.0.1]) by DataIX.net (8.14.4/8.14.4) with ESMTP id p3K0Hcbv084874 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 19 Apr 2011 20:17:39 -0400 (EDT) (envelope-from jhell@DataIX.net) Received: (from jhell@localhost) by DataIX.net (8.14.4/8.14.4/Submit) id p3K0Hcfq084873; Tue, 19 Apr 2011 20:17:38 -0400 (EDT) (envelope-from jhell@DataIX.net) Date: Tue, 19 Apr 2011 20:17:37 -0400 From: "J. Hellenthal" To: Bruce Cran , freebsd-current@freebsd.org Message-ID: <20110420001737.GE2483@DataIX.net> References: <20110419111500.GA16509@muon.cran.org.uk> <20110419122210.GL85668@acme.spoerlein.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XStn23h1fwudRqtG" Content-Disposition: inline In-Reply-To: <20110419122210.GL85668@acme.spoerlein.net> X-OpenPGP-Key-Id: 0x89D8547E X-OpenPGP-Key-Fingerprint: 85EF E26B 07BB 3777 76BE B12A 9057 8789 89D8 547E X-OpenPGP-Key-URL: http://bit.ly/0x89D8547E Cc: Subject: Re: Finding typos using codespell X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2011 00:17:44 -0000 --XStn23h1fwudRqtG Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 19, 2011 at 02:22:10PM +0200, Ulrich Sp=F6rlein wrote: >On Tue, 19.04.2011 at 12:15:00 +0100, Bruce Cran wrote: >> There's a new tool that can be used to find spelling mistakes in code: c= odespell=20 >> from http://www.politreco.com has already been used to find mistakes in = both=20 >> Linux and LLVM. I ran it on sys/ and it found lots of potential typos - = the=20 >> full diff (which I know does contain some incorrect changes) can be foun= d at=20 >> http://www.cran.org.uk/~brucec/freebsd/codespell_sys.diff . > >Needs manual review, but I think this is very useful for the spelling >nazi challenged among us :-) > >False positive, e.g.: > { >- struct ccb_immed_notify *inot; >+ struct ccb_immed_notify *into; > mpt_tgt_state_t *tgt; > >Cheers, >Uli As mentioned here already changes that I have noticed are: (Upper || lower case): inot -> into lsat -> last inbetween -> between ALOT -> A LOT boundry -> boundary "This one seems to have corrected itself." virtualY -> virtually ID -> DID lastr -> last *Any uuencoded file* This was just a review of the functional changes. The no-op changes I just filtered out of the patch to quickly catch the "Bad Thing" changes above. It might just be better to build a list of files with spelling errors and anyone with the next commit to any of those files just runs it through aspell/ispell or whatever they like rather than causing this much of a slush. All in all good find Bruce!. --=20 Regards, J. Hellenthal WWJD --XStn23h1fwudRqtG Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) Comment: http://bit.ly/0x89D8547E iQEcBAEBAgAGBQJNriYhAAoJEJBXh4mJ2FR+WaQH/jYS1pF1kiL73zi1QlpfvjI2 7Vjtmpv2s91ih1URDvf5B+I+IpSiYvMreFhKeAJsBVUXyfILUtO1sSYUh06E2oHf sE6t9cD2q2BndVaXUXvgycYlvDO2r52vpIWqL7hiAufubTLnqNYNVIwYyL0lOuWR zPUxNLCb816iWkynS9vxKIW2hhYjX3Obw3d06rOQ3WRnjOTv8UVPYrw5GgcWdDvo WQetM0GCuhGBYTv64EioCuVnzpN+lbf+H2aoRjJlMeLVpTLigr7aZWlM+Ps1FgTh XRe2Ya5/ys3ZztXh778+RSGbMQWKxoADgcGbLmm5+16qMRkk5B9G7wFzvmN2pgU= =A3Z6 -----END PGP SIGNATURE----- --XStn23h1fwudRqtG--