From owner-cvs-all Sun Jul 9 4:23: 3 2000 Delivered-To: cvs-all@freebsd.org Received: from mercury.mich.com (mercury.mich.com [64.79.64.32]) by hub.freebsd.org (Postfix) with ESMTP id A621F37B6B8; Sun, 9 Jul 2000 04:22:58 -0700 (PDT) (envelope-from will@almanac.yi.org) Received: from argon.gryphonsoft.com (pm003-006.dialup.bignet.net [64.79.80.102]) by mercury.mich.com (8.9.3/8.9.3) with ESMTP id HAA03436; Sun, 9 Jul 2000 07:20:17 -0400 Received: by argon.gryphonsoft.com (Postfix, from userid 1000) id 4FDFF194F; Sun, 9 Jul 2000 07:18:01 -0400 (EDT) Date: Sun, 9 Jul 2000 07:18:01 -0400 From: Will Andrews To: Dag-Erling Smorgrav Cc: Will Andrews , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/ps ps.c Message-ID: <20000709071801.A8857@argon.gryphonsoft.com> References: <200007080513.WAA01643@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0.1i In-Reply-To: ; from des@flood.ping.uio.no on Sun, Jul 09, 2000 at 12:31:42PM +0200 X-Operating-System: FreeBSD 5.0-CURRENT i386 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sun, Jul 09, 2000 at 12:31:42PM +0200, Dag-Erling Smorgrav wrote: > How many scripts does this break, and are you sure you should have > MFCed so quickly? It doesn't break any scripts. There was no way to tell (in the past) if a PID passed to ps(1) existed or not; at least, not by testing the exit code. They would have to check the output instead. And if they're testing whether a PID exists, there's no change. This bugfix probably increases the portability of shell scripts that depend on exit codes. In particular, Netsaint checks the exit code, and will break on FreeBSD versions prior to these commits. Since I'm making a port for Netsaint, I need a working ps(1). -- Will Andrews GCS/E/S @d- s+:+>+:- a--->+++ C++ UB++++ P+ L- E--- W+++ !N !o ?K w--- ?O M+ V-- PS+ PE++ Y+ PGP+>+++ t++ 5 X++ R+ tv+ b++>++++ DI+++ D+ G++>+++ e->++++ h! r-->+++ y? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message