From owner-svn-src-all@FreeBSD.ORG Fri May 21 16:03:57 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D76E2106566B; Fri, 21 May 2010 16:03:57 +0000 (UTC) (envelope-from jh@FreeBSD.org) Received: from svn.freebsd.org (unknown [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id ACA398FC0C; Fri, 21 May 2010 16:03:57 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o4LG3vHx063073; Fri, 21 May 2010 16:03:57 GMT (envelope-from jh@svn.freebsd.org) Received: (from jh@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o4LG3v4p063070; Fri, 21 May 2010 16:03:57 GMT (envelope-from jh@svn.freebsd.org) Message-Id: <201005211603.o4LG3v4p063070@svn.freebsd.org> From: Jaakko Heinonen Date: Fri, 21 May 2010 16:03:57 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-7@freebsd.org X-SVN-Group: stable-7 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r208381 - stable/7/usr.bin/systat X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 May 2010 16:03:58 -0000 Author: jh Date: Fri May 21 16:03:57 2010 New Revision: 208381 URL: http://svn.freebsd.org/changeset/base/208381 Log: MFC r197956: - Catch SIGHUP to perform cleanup before exiting. - Exit if getch() returns with an error other than EINTR. Otherwise systat(1) may get stuck in an infinite loop if it doesn't receive SIGHUP when terminal closes. - Remove attempt to clear stdio error indicators. getch() doesn't use stdio, making it useless. - Remove unneeded masking of getch() return value. PR: bin/107171 Modified: stable/7/usr.bin/systat/keyboard.c stable/7/usr.bin/systat/main.c Directory Properties: stable/7/usr.bin/systat/ (props changed) Modified: stable/7/usr.bin/systat/keyboard.c ============================================================================== --- stable/7/usr.bin/systat/keyboard.c Fri May 21 16:01:57 2010 (r208380) +++ stable/7/usr.bin/systat/keyboard.c Fri May 21 16:03:57 2010 (r208381) @@ -39,8 +39,10 @@ __FBSDID("$FreeBSD$"); static const char sccsid[] = "@(#)keyboard.c 8.1 (Berkeley) 6/6/93"; #endif +#include #include #include +#include #include #include "systat.h" @@ -57,10 +59,11 @@ keyboard() move(CMDLINE, 0); do { refresh(); - ch = getch() & 0177; - if (ch == 0177 && ferror(stdin)) { - clearerr(stdin); - continue; + ch = getch(); + if (ch == ERR) { + if (errno == EINTR) + continue; + exit(1); } if (ch >= 'A' && ch <= 'Z') ch += 'a' - 'A'; Modified: stable/7/usr.bin/systat/main.c ============================================================================== --- stable/7/usr.bin/systat/main.c Fri May 21 16:01:57 2010 (r208380) +++ stable/7/usr.bin/systat/main.c Fri May 21 16:03:57 2010 (r208381) @@ -133,6 +133,7 @@ main(int argc, char **argv) exit(1); } } + signal(SIGHUP, die); signal(SIGINT, die); signal(SIGQUIT, die); signal(SIGTERM, die);