From owner-cvs-src@FreeBSD.ORG  Thu Mar  3 17:35:06 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3966816A4CE; Thu,  3 Mar 2005 17:35:06 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 1E68C43D31; Thu,  3 Mar 2005 17:35:06 +0000 (GMT)
	(envelope-from wpaul@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j23HZ6Ui094850;
	Thu, 3 Mar 2005 17:35:06 GMT
	(envelope-from wpaul@repoman.freebsd.org)
Received: (from wpaul@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j23HZ5hv094849;
	Thu, 3 Mar 2005 17:35:05 GMT
	(envelope-from wpaul)
Message-Id: <200503031735.j23HZ5hv094849@repoman.freebsd.org>
From: Bill Paul <wpaul@FreeBSD.org>
Date: Thu, 3 Mar 2005 17:35:05 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/sys/net80211 ieee80211_ioctl.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Mar 2005 17:35:06 -0000

wpaul       2005-03-03 17:35:05 UTC

  FreeBSD src repository

  Modified files:
    sys/net80211         ieee80211_ioctl.c 
  Log:
  Recently, it was reported to me that you could provoke a double fault
  panic with the NDISulator if you did "ifconfig ndis0 10.0.0.1/24,"
  whereas "ifconfig ndis0 10.0.0.1/24 up" worked fine. The double fault
  was caused by the ifconfig thread running out of kernel stack space.
  (This was partly due to the NDIsulator using a couple of big buffers on
  the stack, but even after fixing that the double fault persisted.)
  
  It turns out that ndis_init() is called in both cases, but in the first
  case the code path passes through ieee80211_ioctl(), and it turns out
  ieee80211_ioctl() consumes a whopping 2400 bytes of stack space.
  Apparently, gcc -O2 causes the ieee80211_ioctl_get80211() routine to
  be inlined into ieee80211_ioctl(), and for some reason which I do not
  fully understand, this causes ieee80211_ioctl() to consume an extra 2K
  of stack space.
  
  To prevent this overly agressive optimization, ieee80211_ioctl_get80211()
  is now declared with __attribute__ ((noinline)). With this change,
  ieee80211_ioctl() now only reserves about 200 bytes of stack instead of 2400.
  
  Revision  Changes    Path
  1.19      +19 -0     src/sys/net80211/ieee80211_ioctl.c