From owner-p4-projects@FreeBSD.ORG Wed Dec 5 17:25:34 2007 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 2153C16A41B; Wed, 5 Dec 2007 17:25:34 +0000 (UTC) Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DB64A16A418 for ; Wed, 5 Dec 2007 17:25:33 +0000 (UTC) (envelope-from hselasky@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id CD90F13C4E5 for ; Wed, 5 Dec 2007 17:25:33 +0000 (UTC) (envelope-from hselasky@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id lB5HPXGV084404 for ; Wed, 5 Dec 2007 17:25:33 GMT (envelope-from hselasky@FreeBSD.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id lB5HPXGS084401 for perforce@freebsd.org; Wed, 5 Dec 2007 17:25:33 GMT (envelope-from hselasky@FreeBSD.org) Date: Wed, 5 Dec 2007 17:25:33 GMT Message-Id: <200712051725.lB5HPXGS084401@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to hselasky@FreeBSD.org using -f From: Hans Petter Selasky To: Perforce Change Reviews Cc: Subject: PERFORCE change 130278 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Dec 2007 17:25:34 -0000 http://perforce.freebsd.org/chv.cgi?CH=130278 Change 130278 by hselasky@hselasky_laptop001 on 2007/12/05 17:25:18 Bug fix. The XXX_WAIT_COMMAND flag is not always cleared when set in "{ural,rum}_newstate_cb". This causes all IEEE80211 frames to be halted until a new command is issued in some cases. This causes the IEEE80211 layer to not complete association among other things. Affected files ... .. //depot/projects/usb/src/sys/dev/usb/if_rum.c#20 edit .. //depot/projects/usb/src/sys/dev/usb/if_ural.c#44 edit Differences ... ==== //depot/projects/usb/src/sys/dev/usb/if_rum.c#20 (text+ko) ==== @@ -1761,9 +1761,6 @@ DPRINTF(sc, 0, "setting new state: %d\n", nstate); - /* force data to wait */ - sc->sc_flags |= RUM_FLAG_WAIT_COMMAND; - /* set new state first! */ (sc->sc_newstate) (ic, nstate, arg); ==== //depot/projects/usb/src/sys/dev/usb/if_ural.c#44 (text+ko) ==== @@ -1867,9 +1867,6 @@ DPRINTF(sc, 0, "setting new state: %d\n", nstate); - /* force data to wait */ - sc->sc_flags |= URAL_FLAG_WAIT_COMMAND; - /* set new state first! */ (sc->sc_newstate) (ic, nstate, arg);