Date: Wed, 25 May 2016 21:57:32 -0400 From: Patrick Kelsey <pkelsey@freebsd.org> To: Adrian Chadd <adrian@freebsd.org> Cc: "freebsd-mips@freebsd.org" <freebsd-mips@freebsd.org>, "freebsd-arm@freebsd.org" <freebsd-arm@freebsd.org>, Ruslan Bukin <br@freebsd.org> Subject: Re: svn commit: r298274 - head/sys/dev/spibus Message-ID: <CAD44qMWAEGYJWANW6-4Pf-cCcgsRP_JYbSNhz6Xtv8AM%2BHwD0w@mail.gmail.com> In-Reply-To: <CAJ-Vmokwd2wYDMrHQYGBbfvDZ6=32EatZp3k-j1cwUYDMFf%2BTg@mail.gmail.com> References: <201604191539.u3JFdkHx048678@repo.freebsd.org> <CAJ-VmonyZR-CiPxceAvVzxDjL7WXDAix-Pmj2RRqp%2B9gj3u0hA@mail.gmail.com> <20160419171243.GA30453@bsdpad.com> <CACVs6=_pN9VAz1kkQQAL-ftKof%2Bkkn5MgxDP1kWj9kM-x=AzbQ@mail.gmail.com> <1461097280.1232.34.camel@freebsd.org> <CAD44qMV1bRA9USafKLSdKv8CcES34G8Kbt54OspaAA_Xdb07xg@mail.gmail.com> <CAJ-Vmo=GiP_NXfBz5ZsJkBm8Ypm-t0udZRqX9BkTa0KuC1bvrw@mail.gmail.com> <CAD44qMWJeTNuXS%2BB1ecJUFN63dweYZRKKG4Ek7kxMk-Mme7=%2BQ@mail.gmail.com> <CAD44qMWbOUaveDtq%2BHn_cYAiU_VGwFEgYJ1vSFYv=4G9XSzzbQ@mail.gmail.com> <CAJ-Vmokwd2wYDMrHQYGBbfvDZ6=32EatZp3k-j1cwUYDMFf%2BTg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 20, 2016 at 2:35 AM, Adrian Chadd <adrian@freebsd.org> wrote: > I've reviewed the patches from luiz, and these look fine. but indeed, > this patchset does set/release the bus each transaction so we can do > multiple transactions whilst holding the bus. > > Which is fine, but it means I have to undo ruslan's removal in the below > commit. > > I'm happy to run through and do each of the spi bus drivers (as there > are more now than the two you patched) but it's a bit close to the > 11.0-release cycle to go and churn the spibus code. > > But, if people think it's worth doing it so we can try to get mmcspi > into the tree before 11.0-rel is cut, I'm happy to run through and do > it. I actually have some AR9331 stuff now that could use mmcspi. :) > > What do people think? > > Thanks, Adrian. My opinion is that the changes to the spi bus interface and the corresponding changes to the spi bus drivers you are talking about are very straightforward and low risk. There is non-zero other interest out there in using the mmcspi driver, based on the couple of emails I've received seeking help on the subject in the last six months or so, so I don't think this would be just a commit for the sake of getting some interesting new code in. -Patrick
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAD44qMWAEGYJWANW6-4Pf-cCcgsRP_JYbSNhz6Xtv8AM%2BHwD0w>