From owner-svn-src-all@freebsd.org Tue Apr 30 14:46:18 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6DAD71594106 for ; Tue, 30 Apr 2019 14:46:18 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 115A97545C for ; Tue, 30 Apr 2019 14:46:18 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x72e.google.com with SMTP id c190so8277337qke.9 for ; Tue, 30 Apr 2019 07:46:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uOXalQIAh8UZo3dnH20BOfxLQJOx9pKBtjX6uDphisA=; b=F7W7MJ4tkTp70vmIFw91w7ZgT845c7vL279+neDTGjB4jGd+PgXmpL1CBesXn7tmpj yrirl4dbhWbvPJXUH1pw9v9QdPxXsESkYeON6khILjChCNayjpZE+mZqjw0MEaHS0XCl xE5dhK5ejb+5G99OmOCs7I5FqjcWZwYMZOCV8xCPxMczssaaaM7fGFTznyV0a9Virfp+ GLEfHZ681G7P1El+qTwmrZu79IEjHvcqm5LNCtjiP+qBTBncctPVnvIKG0bf4O8DjoK2 cim46Q9eTAypFH15m61Mi8j5my+Re99npJ3drQogufn5zYO1rDdRI8ERU1wE26GsGquw ruOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uOXalQIAh8UZo3dnH20BOfxLQJOx9pKBtjX6uDphisA=; b=pxyfvWTNvTTQF2yIwQFUn9kFgyD1v35OJgNkESSSiBFtJJcvG82fqHny/VD4l/BP11 UPzMGq2b4e95aIYO9HeF2cbmkIdkanpWRD70TFaAv8Lxxj7Y4PLZWlH6a5W86MTk2n68 s1nWV5fkfV0QV+jn8Ytrci8mh4qb3XfDRhyUl4F+P+Z/KsZh2IKiXazm6f9Ek/mfzJBG f91OTFomFkbumuVJUG7KMkqSee0fy70aLvXwlegTbXDuOD7l+nFFKqLhWEx7+/HFQldO GmjXe9qO7tXglYn5nN3BOkjPNoLVQ36w5OrtYF4Yx9O+D3G4tJFAOSMqGY+5PgB8PQ6S ZpjA== X-Gm-Message-State: APjAAAXE8vJiLwyjqClQirHnziYMEsS1eJVGqfHeNvqesk6Vk5evBAKW Jw/a6udNDiU3HY9gbtQR8qwlggPe9nq4qYBwl9sY2Q== X-Google-Smtp-Source: APXvYqw95v1HJNjFq6NxXANx2HJSYKFAedxbUN0WCX2cuyCFXTfg1tbtGGA16U2DXAE83wwuKEXXZ3z9oML/lvNewuM= X-Received: by 2002:a05:620a:1014:: with SMTP id z20mr21135229qkj.258.1556635577124; Tue, 30 Apr 2019 07:46:17 -0700 (PDT) MIME-Version: 1.0 References: <201904292205.x3TM5Q7Z058461@repo.freebsd.org> <20190430060849.GB97846@FreeBSD.org> <20190430142641.GA34567@raichu> In-Reply-To: <20190430142641.GA34567@raichu> From: Warner Losh Date: Tue, 30 Apr 2019 08:46:05 -0600 Message-ID: Subject: Re: svn commit: r346932 - head/sys/ufs/ufs To: Mark Johnston Cc: Alexey Dokuchaev , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 115A97545C X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.994,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Apr 2019 14:46:18 -0000 On Tue, Apr 30, 2019 at 8:27 AM Mark Johnston wrote: > On Tue, Apr 30, 2019 at 06:08:49AM +0000, Alexey Dokuchaev wrote: > > On Mon, Apr 29, 2019 at 10:05:26PM +0000, Mark Johnston wrote: > > > New Revision: 346932 > > > URL: https://svnweb.freebsd.org/changeset/base/346932 > > > > > > Log: > > > Optimize lseek(SEEK_DATA) on UFS. > > > > > > This version fixes the problems identified in r345244. > > > > > > Reviewed by: kib > > > @@ -56,6 +56,9 @@ __FBSDID("$FreeBSD$"); > > > #include > > > #include > > > > > > +static ufs_lbn_t lbn_count(struct ufsmount *, int); > > > +static int readindir(struct vnode *, ufs_lbn_t, ufs2_daddr_t, struct > buf **); > > > > Is the prototype for static readindir() really needed here? > > Yes, when using a K&R definition. > > > > +static int > > > +readindir(vp, lbn, daddr, bpp) > > > + struct vnode *vp; > > > + ufs_lbn_t lbn; > > > + ufs2_daddr_t daddr; > > > + struct buf **bpp; > > > > Don't we prefer ASNI declarations over K&R these days? > > Yes, I was just staying consistent with the rest of the file. For new code, we do prefer ANSI prototypes and function definitions. But for ufs and friends, we're still using K&R for a variety of reasons. Warner