Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 30 Nov 2005 08:20:13 -0500
From:      John Baldwin <jhb@freebsd.org>
To:        Robert Watson <rwatson@freebsd.org>
Cc:        cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject:   Re: cvs commit: src/sys/kern uipc_socket.c
Message-ID:  <200511300820.15431.jhb@freebsd.org>
In-Reply-To: <20051130091930.K95395@fledge.watson.org>
References:  <200511292307.jATN7EJH055853@repoman.freebsd.org> <20051130091930.K95395@fledge.watson.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 30 November 2005 04:20 am, Robert Watson wrote:
> On Tue, 29 Nov 2005, John Baldwin wrote:
> >  Fix snderr() to not leak the socket buffer lock if an error occurs in
> >  sosend().  Robert accidentally changed the snderr() macro to jump to t=
he
> >  out label which assumes the lock is already released rather than the
> >  release label which drops the lock in his previous change to sosend().
> >  This should fix the recent panics about returning from write(2) with t=
he
> >  socket lock held and the most recent LOR on current@.
>
> Thanks for fixing this -- I ran this patch in testing for ages, but must
> have done some "clean up" or other such 99.85% harmless activity :-(.

No problem.  At least you didn't commit it and then immediately leave for a=
=20
small island in the Carribbean without any inet access for a week. :)

=2D-=20
John Baldwin <jhb@FreeBSD.org> =A0<>< =A0http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve" =A0=3D =A0http://www.FreeBSD.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200511300820.15431.jhb>