From owner-freebsd-hackers Mon Sep 18 14:15:36 1995 Return-Path: owner-hackers Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id OAA02959 for hackers-outgoing; Mon, 18 Sep 1995 14:15:36 -0700 Received: from phaeton.artisoft.com (phaeton.Artisoft.COM [198.17.250.211]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id OAA02952 ; Mon, 18 Sep 1995 14:15:31 -0700 Received: (from terry@localhost) by phaeton.artisoft.com (8.6.11/8.6.9) id OAA08660; Mon, 18 Sep 1995 14:13:02 -0700 From: Terry Lambert Message-Id: <199509182113.OAA08660@phaeton.artisoft.com> Subject: Re: why is this not a bug in namei? To: bde@zeta.org.au (Bruce Evans) Date: Mon, 18 Sep 1995 14:13:02 -0700 (MST) Cc: hackers@freefall.freebsd.org, julian@freefall.freebsd.org In-Reply-To: <199509181114.VAA20899@godzilla.zeta.org.au> from "Bruce Evans" at Sep 18, 95 09:14:26 pm X-Mailer: ELM [version 2.4 PL24] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Length: 622 Sender: owner-hackers@FreeBSD.org Precedence: bulk > >if HASBUF was set, we have freed something we didn't allocate.. > >(whenever we get an error, by the looks of it..) > > It seems that error handlers are required to free the buffer no matter > where it was allocated and everything is supposed to ignore HASBUF > (perhaps everything in *cnp?) after an error. Except if SAVESTART is > set, then only the caller must free. Promise to do the NFS server code (nfs_namei()), and I'll send you the patches to fix all other instances. Terry Lambert terry@lambert.org --- Any opinions in this posting are my own and not those of my present or previous employers.