Date: Sun, 16 Dec 2007 13:08:29 -0300 From: "Alejandro Pulver" <alepulver@FreeBSD.org> To: "FreeBSD gnats submit" <FreeBSD-gnats-submit@FreeBSD.org> Subject: ports/118749: [PATCH] bsd.commands.mk: add missing UNMAKESELF_CMD, required by USE_MAKESELF Message-ID: <1197821309.2615@deimos.mars.bsd> Resent-Message-ID: <200712161610.lBGGA0qJ081234@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 118749
>Category: ports
>Synopsis: [PATCH] bsd.commands.mk: add missing UNMAKESELF_CMD, required by USE_MAKESELF
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Sun Dec 16 16:10:00 UTC 2007
>Closed-Date:
>Last-Modified:
>Originator: Alejandro Pulver
>Release: FreeBSD 6.2-RELEASE i386
>Organization:
>Environment:
System: FreeBSD 6.2-RELEASE #0: Fri Jan 12 11:05:30 UTC 2007
root@dessler.cse.buffalo.edu:/usr/obj/usr/src/sys/SMP
>Description:
The (relatively) new USE_MAKESELF doesn't work because it leaves
EXTRACT_CMD undefined, thus later trying to execute the distfile.
>From bsd.port.mk:
.elif defined(USE_MAKESELF)
EXTRACT_CMD?= ${UNMAKESELF_CMD}
But it's not defined, so it should be added in bsd.commands.mk as
UNZIP_CMD, etc.
>How-To-Repeat:
>Fix:
Index: ports/Mk/bsd.commands.mk
===================================================================
RCS file: /home/pcvs/ports/Mk/bsd.commands.mk,v
retrieving revision 1.1
diff -u -r1.1 bsd.commands.mk
--- ports/Mk/bsd.commands.mk 4 Aug 2007 11:37:23 -0000 1.1
+++ ports/Mk/bsd.commands.mk 16 Dec 2007 15:55:51 -0000
@@ -83,6 +83,7 @@
TRUE?= true # Shell builtin
UMOUNT?= /sbin/umount
UNAME?= /usr/bin/uname
+UNMAKESELF_CMD?= ${LOCALBASE}/bin/unmakeself
UNZIP_CMD?= ${LOCALBASE}/bin/unzip
WHICH?= /usr/bin/which
XARGS?= /usr/bin/xargs
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1197821309.2615>