From owner-svn-src-all@freebsd.org Tue Apr 30 15:17:05 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 01C4B1595299; Tue, 30 Apr 2019 15:17:05 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [88.99.82.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9551076AFE; Tue, 30 Apr 2019 15:17:04 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2016.home.selasky.org (unknown [176.74.212.121]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id E983326026E; Tue, 30 Apr 2019 17:17:02 +0200 (CEST) Subject: Re: svn commit: r346958 - head/sys/compat/linuxkpi/common/src To: Niclas Zeising , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201904301041.x3UAfLvj054368@repo.freebsd.org> <8f360678-2df1-fe7b-cb83-f47923534826@freebsd.org> From: Hans Petter Selasky Message-ID: <2f77d9f2-833d-f614-e193-a369086c01cf@selasky.org> Date: Tue, 30 Apr 2019 17:16:34 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <8f360678-2df1-fe7b-cb83-f47923534826@freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 9551076AFE X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.97)[-0.966,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Apr 2019 15:17:05 -0000 On 4/30/19 3:10 PM, Niclas Zeising wrote: > On 2019-04-30 12:41, Hans Petter Selasky wrote: >> Author: hselasky >> Date: Tue Apr 30 10:41:20 2019 >> New Revision: 346958 >> URL: https://svnweb.freebsd.org/changeset/base/346958 >> >> Log: >>    Reduce the number of mutexes after r346645 in the LinuxKPI. >>    Make function macro wrappers for locking and unlocking to ease >> readability. >>    No functional change. >>    Discussed with:        kib@, tychon@ and zeising@ > > I was not part of any discussion regarding this.  If this is related to > https://reviews.freebsd.org/D20097 I explicitly asked you on gitter to > hold of for a bit, while we try to figure out why we are seeing > regressions in graphics with the latest dmar changes. > > Can you please revert this since it colludes the dmar graphics issue, > and it makes the suggested patch not apply cleanly, which makes it > harder to get people to help test. > Thank you! > Regards In response to your request I've collected fixes for all the known LinuxKPI+DMA issues at: https://reviews.freebsd.org/D20097 It is based on top of the latest -current. --HPS