Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 13 Dec 2008 13:24:25 -0700 (MST)
From:      Warner Losh <imp@bsdimp.com>
To:        max@love2party.net
Cc:        src-committers@FreeBSD.org, current@FreeBSD.org, freebsd-virtualization@FreeBSD.org, freebsd-net@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org
Subject:   Re: HEADS UP: vimage - virtualized global variables in the network stack
Message-ID:  <20081213.132425.41724046.imp@bsdimp.com>
In-Reply-To: <200812132045.17207.max@love2party.net>
References:  <200812131913.mBDJD38C037353@svn.freebsd.org> <20081213191345.M97918@maildrop.int.zabbadoz.net> <200812132045.17207.max@love2party.net>

next in thread | previous in thread | raw e-mail | index | archive | help
From: Max Laier <max@love2party.net>
Subject: Re: HEADS UP: vimage - virtualized global variables in the network stack
Date: Sat, 13 Dec 2008 20:45:16 +0100

> On Saturday 13 December 2008 20:33:53 Bjoern A. Zeeb wrote:
> ...
> > This state of having the variables in parallel, global and in the
> > container struct, will be maintained for another (short) time until
> > the entire virtualization framework is in. This is needed, so that
> > all three possible states can be benchmarked from exactly the same
> > code changeset.
> >
> >
> > For developers comitting new code or changing code it is important to
> > properly add virtualized variables in the way that:
> > 1) the globals and externs (if needed) are added/kept in sync as both
> >     a) globals under #ifdef VIMAGE_GLOBALS and b) to the appropriate
> >     container struct + the V_ macro.
> >     When used somewhere in code one has to use the V_foobarbaz version.
> 
> Is there (an easy) way to have the tinderbox build every other run without 
> VIMAGE_GLOBALS so that the most obvious error (global available, but not in 
> the container struct - or the other way around) can be warned about?

This actually points out why the 'tinderbox' name is bogus for the
universe plus failure: universe builds all the kernels.  Tinderbox
builds LINT only.

Warner



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081213.132425.41724046.imp>