Date: Sun, 23 Jun 2019 10:47:37 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Mark Linimon <linimon@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r504884 - in head/devel/xeus: . files Message-ID: <20190623104737.GB22325@FreeBSD.org> In-Reply-To: <201906221919.x5MJJdap098571@repo.freebsd.org> References: <201906221919.x5MJJdap098571@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jun 22, 2019 at 07:19:39PM +0000, Mark Linimon wrote: > New Revision: 504884 > URL: https://svnweb.freebsd.org/changeset/ports/504884 > > Log: > For GCC-based systems, edit top-level CMakeLists.txt to eliminate > either of the following two problems: > > g++8: error: unrecognized command line option '-march=native' > g++8: error: unrecognized argument in option '-mtune=generic' > > [...] > > -.include <bsd.port.mk> > +.include <bsd.port.pre.mk> > + > +.if ${CHOSEN_COMPILER_TYPE} == gcc > +EXTRA_PATCHES= ${FILESDIR}/extra-patch-CMakeLists.txt > +.endif Why conditional patch? We typically abstain from any -march/-mtune with any compiler since it might result that the package built on our cluster would segfault or otherwise work badly on some user's machine. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190623104737.GB22325>