From owner-svn-ports-head@freebsd.org  Sun Jun 23 10:47:38 2019
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7419215CCDF2;
 Sun, 23 Jun 2019 10:47:38 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 1BE4D851DD;
 Sun, 23 Jun 2019 10:47:38 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id EFC8611CBB; Sun, 23 Jun 2019 10:47:37 +0000 (UTC)
Date: Sun, 23 Jun 2019 10:47:37 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Mark Linimon <linimon@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r504884 - in head/devel/xeus: . files
Message-ID: <20190623104737.GB22325@FreeBSD.org>
References: <201906221919.x5MJJdap098571@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201906221919.x5MJJdap098571@repo.freebsd.org>
User-Agent: Mutt/1.11.4 (2019-03-13)
X-Rspamd-Queue-Id: 1BE4D851DD
X-Spamd-Bar: ------
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-6.98 / 15.00];
 NEURAL_HAM_MEDIUM(-1.00)[-0.998,0];
 NEURAL_HAM_SHORT(-0.99)[-0.986,0]; REPLY(-4.00)[];
 NEURAL_HAM_LONG(-1.00)[-1.000,0]
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Jun 2019 10:47:38 -0000

On Sat, Jun 22, 2019 at 07:19:39PM +0000, Mark Linimon wrote:
> New Revision: 504884
> URL: https://svnweb.freebsd.org/changeset/ports/504884
> 
> Log:
>   For GCC-based systems, edit top-level CMakeLists.txt to eliminate
>   either of the following two problems:
>   
>     g++8: error: unrecognized command line option '-march=native'
>     g++8: error: unrecognized argument in option '-mtune=generic'
>   
> [...]
>  
> -.include <bsd.port.mk>
> +.include <bsd.port.pre.mk>
> +
> +.if ${CHOSEN_COMPILER_TYPE} == gcc
> +EXTRA_PATCHES=	${FILESDIR}/extra-patch-CMakeLists.txt
> +.endif

Why conditional patch?  We typically abstain from any -march/-mtune
with any compiler since it might result that the package built on our
cluster would segfault or otherwise work badly on some user's machine.

./danfe