From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Oct 31 07:20:00 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id C2AD2F60 for ; Thu, 31 Oct 2013 07:20:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A274D2566 for ; Thu, 31 Oct 2013 07:20:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r9V7K0FL061498 for ; Thu, 31 Oct 2013 07:20:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r9V7K0YK061497; Thu, 31 Oct 2013 07:20:00 GMT (envelope-from gnats) Resent-Date: Thu, 31 Oct 2013 07:20:00 GMT Resent-Message-Id: <201310310720.r9V7K0YK061497@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, John Marino Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id C2E3AD6E for ; Thu, 31 Oct 2013 07:11:06 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B18D1251E for ; Thu, 31 Oct 2013 07:11:06 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r9V7B5Lw099964 for ; Thu, 31 Oct 2013 07:11:05 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r9V7B5A6099793; Thu, 31 Oct 2013 07:11:05 GMT (envelope-from nobody) Message-Id: <201310310711.r9V7B5A6099793@oldred.freebsd.org> Date: Thu, 31 Oct 2013 07:11:05 GMT From: John Marino To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/183513: [PATCH] cad/feappv: post-patch target makes matches that can never be true X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Oct 2013 07:20:00 -0000 >Number: 183513 >Category: ports >Synopsis: [PATCH] cad/feappv: post-patch target makes matches that can never be true >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Oct 31 07:20:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: John Marino >Release: >Organization: >Environment: >Description: The post-patch target tries to replace several lines in ${WRKSRC}/makefile.in. The problem that sed will never match some of the replaces. Specially, sed assumes FFOPTFLAG and CCOPTFLAG start at the beginning of the line. Perhaps it did in a previous version, but now it doesn't. In order for these flags to be defined, the attached patch to makefile.in has to be added. It removes the whitespace in Makefile.in, allowing the post-patch target to work. An alternative approach is to modify the post-patch target to not start at the beginning of the line, but this will also change the commented version (which in the end, doesn't really matter as there is makefile.in.bak with the original version as a result) >How-To-Repeat: >Fix: Patch attached with submission follows: --- cad/feappv/files/patch-makefile.in.orig 2013-10-31 07:08:31.626902000 +0000 +++ cad/feappv/files/patch-makefile.in @@ -1 +1,13 @@ - +--- makefile.in.orig 2013-07-15 19:15:37.000000000 +0000 ++++ makefile.in +@@ -31,8 +31,8 @@ FF = gfortran + CC = gcc + + # What optimization level to use +- FFOPTFLAG = -O3 -ftree-vectorize -Wall +- CCOPTFLAG = -O3 -ftree-vectorize -Wall ++FFOPTFLAG = -O3 -ftree-vectorize -Wall ++CCOPTFLAG = -O3 -ftree-vectorize -Wall + + # FFOPTFLAG = -g -O3 -ftree-vectorize -Wall + # CCOPTFLAG = -g -O3 -ftree-vectorize -Wall >Release-Note: >Audit-Trail: >Unformatted: