Date: Tue, 23 Aug 2005 17:39:49 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Suleiman Souhlal <ssouhlal@FreeBSD.org> Cc: cvs-src@FreeBSD.org, Scott Long <scottl@samsco.org>, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_vfsops.c Message-ID: <20050823172734.Q70244@delplex.bde.org> In-Reply-To: <55E14A30-FB7A-4F3A-9EC5-D9CECFFB3416@FreeBSD.org> References: <200508212206.j7LM6fGR076152@repoman.freebsd.org> <43094CA1.8020905@samsco.org> <55E14A30-FB7A-4F3A-9EC5-D9CECFFB3416@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 22 Aug 2005, Suleiman Souhlal wrote: > On Aug 22, 2005, at 5:55 AM, Scott Long wrote: > >> Suleiman Souhlal wrote: >> >>> ssouhlal 2005-08-21 22:06:41 UTC >>> FreeBSD src repository >>> Modified files: >>> sys/ufs/ffs ffs_vfsops.c Log: >>> Set the mountpoint path in the superblock (fs_fsmnt) at mount-time >>> so that it appears in the various messages (not cleanly unmounted, >>> filesystem full, etc). This has been broken since rev 1.261. >>> Revision Changes Path >>> 1.292 +2 -1 src/sys/ufs/ffs/ffs_vfsops.c >>> >> >> What was wrong with vfs_mountedfrom()? > > The string it expects is the path to a device, and not to a mountpoint. > We already call it in ffs_mount() with the right path. The main difference is actually that vfs_mountedfrom() copies from ffs to vfs, but copying from vfs to ffs is wanted. The direction of the copy is verbosely documented in a comment immediately before the code: /* * Set FS local "last mounted on" information (NULL pad) */ ^^^^^^^^ ^^^^^^^^^^ The largest of the style bugs in rev.1.261 was that it left this comment not even echoing the code. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050823172734.Q70244>