Date: Tue, 7 Mar 2017 00:51:10 -0800 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: rgrimes@freebsd.org Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r314833 - in head: bin/pkill lib/libxo/tests/encoder libexec/rtld-elf share/termcap usr.bin/chpass usr.bin/passwd usr.sbin/bsdinstall/partedit usr.sbin/mailwrapper usr.sbin/nologin Message-ID: <7544F39D-EFC9-4685-9238-67A45D7FE037@gmail.com> In-Reply-To: <201703070550.v275oOE5092697@pdx.rh.CN85.dnsmgr.net> References: <201703070550.v275oOE5092697@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_76AA0D18-8A7B-4DC3-BC2D-06CEDE271722 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Mar 6, 2017, at 21:50, Rodney W. Grimes = <freebsd@pdx.rh.CN85.dnsmgr.net> wrote: >=20 >>> On Mar 6, 2017, at 21:10, Rodney W. Grimes <rgrimes@FreeBSD.org> = wrote: >>>=20 >>> Author: rgrimes >>> Date: Tue Mar 7 05:10:38 2017 >>> New Revision: 314833 >>> URL: https://svnweb.freebsd.org/changeset/base/314833 > ... >=20 >>>=20 >>> -SYMLINKS+=3D ${LIBDIR}/${SHLIB_NAME} = /usr/lib/libxo/encoder/test.enc >>> +SYMLINKS+=3D ../../../tests/lib/libxo/${SHLIB_NAME} = /usr/lib/libxo/encoder/test.enc >>=20 >> This change breaks setting TESTSBASE !=3D /usr/tests . Please = fix (my employer depends on this being functional). >> Thanks, >=20 > I am just going to revert this until the issue with SYMLINKS vs = RSYMLINKS and > probably a much better fix in bsd.*.mk can be implemented. I can live = with > one last nasty wart of an absolute link in DESTDIR until then. The = important > functional ones are gone now. >=20 > To fix this without changing SYMLINKS would involve adding a local = install: > target which would be more mess than having the one absolute link. The proposed enhancement for bsd.links.mk for RSYMLINKS can be found = here: https://reviews.freebsd.org/D9919 . Thanks, -Ngie --Apple-Mail=_76AA0D18-8A7B-4DC3-BC2D-06CEDE271722 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYvnR+AAoJEPWDqSZpMIYVypEQAI+jhE0jkncLufM5Z3/KacPv xG8kFydf/ObUApPWEyegYI/XVIiotVvyc4dTFIVvvwxiFENka3DtjDswUx+VDne5 rPyMDN8WGuceXgkcQf0Aey/br7jOtbIkZpgVxkYIl0y/txujo9LfltAh1Jtz9Kt8 a295o4kIWdBuFUXlJ6Avx4BS60fW9uVAV/p1xQe6tRbHtpmzLGE2JSYkEyQ+WzVk +ASwCOdXF0vR+0kCTqrHI1wNMAZdTYYvyGhX/uTolomCQXI9Oyl2dG66PmXYxLf3 05h1THuBdXaaUVZtDxoa1pi5JmiUFH7t4L+z85LVD/S04ZNL0h+sJ6V7zCQzrvv2 1eLEtDIKVD0VzZLye6smmExLlfCdI9TC0Oa82+tMnPwhEIyFQRQyOi847OoxQeCL LaxZayHuNejOnzwtcXn4ZCuGAPTMXXnJHV14dUA2Q3bmNGk3CzU3uZaOlVyUnIer WMJ0yywF4dJfaHbqBpa08OqDtqLommmStOIn7Xb2N2W0QbVw6RbBWChq8mJCAuES bGGpIp2i3nT47vOuWyzwvSZsNe7iJjmX5YKrNwSuiGSIRYk0DIMKSfxtDGzhKeHW JluGTIWDq/lsT3n+nirD00/KfsYfDv+QuUq+nfh6t/yq6MjyOSdz9OugqZ4o5k9V JPbm4lGH3M9UbsI2xh+F =CE+3 -----END PGP SIGNATURE----- --Apple-Mail=_76AA0D18-8A7B-4DC3-BC2D-06CEDE271722--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7544F39D-EFC9-4685-9238-67A45D7FE037>