Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 23 Jul 2018 11:02:13 -0700
From:      John Baldwin <jhb@FreeBSD.org>
To:        rgrimes@freebsd.org
Cc:        Peter Jeremy <peter@rulingia.com>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   Re: svn commit: r336448 - stable/10
Message-ID:  <7d86153b-8442-27a3-f152-475116c6b1f5@FreeBSD.org>
In-Reply-To: <201807231736.w6NHadhr032631@pdx.rh.CN85.dnsmgr.net>
References:  <201807231736.w6NHadhr032631@pdx.rh.CN85.dnsmgr.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On 7/23/18 10:36 AM, Rodney W. Grimes wrote:
>> On 7/18/18 12:05 PM, Peter Jeremy wrote:
>>> On 2018-Jul-18 07:41:23 -0700, "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> wrote:
>>>>> Author: peterj
>>>>> Date: Wed Jul 18 09:32:43 2018
>>>>> New Revision: 336448
>>>>> URL: https://svnweb.freebsd.org/changeset/base/336448
>>>>>
>>>>> Log:
>>>>>   Retrospectively document SVN branch point for stable-10 and its releases.
>>>>>   
>>>>>   This is a direct commit to stable/10 because the releases are taken
>>>>>   from the stable/10 branch.
>>>>>   
>>>>>   Approved by:	jhb (mentor)
>>>>>   Differential Revision:	D16263
>>>>
>>>> Actually I see no reason not to document these in the mainline
>>>> UPDATING file and making these MFC's.  As is now when looking
>>>> at UPDATING from head I can not easily find the branch point
>>>> for any of these releases and that is probably the most useful
>>>> time for this information.  If I already have a branch I probably
>>>> already know what its anchor point is.
>>>
>>> I only put the releng/x.y branch points into the relevant stable/x/UPDATING
>>> because releng/x.y is branched off stable/x and I don't think it makes much
>>> sense to document those in head/UPDATING.  The stable/x branchpoints are in
>>> both head/UPDATING and stable/x/UPDATING.  Note that the stable/10 branch-
>>> point was already in head/UPDATING.
>>
>> I agree with this.  We should document them in the source branch, but not
>> in grandparents like head where there is no single head commit that becomes
>> releng/X.Y.
> 
> My only counter to this is that often what I am investigating is
> the change between ^head/ and some release, say 11.2 and I really
> do not want to go grovel in stable/11 to find the rXXXXXX for 11.2,
> that is just a PITA.  Though the branch point for stable/11 is interesting,
> it is rarely usefull for any thing very meaningful.

I don't ever grovel around for this in either stable/11 or head to be honest.
I usually use the svnweb interface, but doing the svn log quoted previously
against a little changed-file on the branch in question (such as MAINTAINERS)
via the url is really the better answer.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7d86153b-8442-27a3-f152-475116c6b1f5>