From owner-svn-src-all@FreeBSD.ORG Fri Feb 27 15:46:42 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C3503C77 for ; Fri, 27 Feb 2015 15:46:42 +0000 (UTC) Received: from mail-pd0-f176.google.com (mail-pd0-f176.google.com [209.85.192.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8678ACE0 for ; Fri, 27 Feb 2015 15:46:42 +0000 (UTC) Received: by pdbnh10 with SMTP id nh10so21793376pdb.11 for ; Fri, 27 Feb 2015 07:46:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=fGVgtl+lsv5kcAlrP9xgggL+TUrSHJWLCdFA+b6eHGI=; b=SywPwCbwXIjcul1XUu8cIVhfD2xC8YfDxu0lm4pNXZVNqnvMT+53rNnNyi3kdBe1D7 8aTJ1onpb8a2U8BgZ7R5/IwIyMQOqSEmcTFP+fwm+Ng4yEBTrxvR64BTghGKcRReMD2W iNYS4NmBGjV/YZR9v1SQzFBsdiI9yFR2EBQdI4XvY2AI7+OWwAm+VVv+KTjMcpecl0xR iJynQUNW4rV91YxNQnSwrwzdV8QAHsCYKwm9/ewZstfeaNkjY/csKi2Kjmk6LqW+FZQz 9CPh1JuSiSg9ICgzc74wYt2cRh0XGR+4Bz87OQ3kh/wxdHywf4ON98c4tk9oRbYKlHDU 6bCg== X-Gm-Message-State: ALoCoQlgOpcEeA2qAoTS6W0IwJ5fKZi4V2U5S70C+Zd/ivf0igS9j6ng3VTLPlWFoPWfedxNtzZO X-Received: by 10.70.40.237 with SMTP id a13mr25495921pdl.82.1425051996076; Fri, 27 Feb 2015 07:46:36 -0800 (PST) Received: from [10.64.26.6] ([69.53.236.236]) by mx.google.com with ESMTPSA id y2sm4370476pdm.31.2015.02.27.07.46.34 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 27 Feb 2015 07:46:35 -0800 (PST) Sender: Warner Losh Subject: Re: svn commit: r279349 - head/sys/kern Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_DFD6C50D-D254-4C7D-92AB-B7BEA1A18D26"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5b5 From: Warner Losh In-Reply-To: Date: Fri, 27 Feb 2015 08:46:32 -0700 Message-Id: References: <201502270256.t1R2uxnv085328@svn.freebsd.org> <20150227082257.3fb1081c@bender.Home> <20150227202646.I2088@besplex.bde.org> To: Ed Maste X-Mailer: Apple Mail (2.2070.6) Cc: Benjamin Kaduk , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , Andrew Turner , Bruce Evans , "svn-src-head@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Feb 2015 15:46:43 -0000 --Apple-Mail=_DFD6C50D-D254-4C7D-92AB-B7BEA1A18D26 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Sure wish my code review got this much love=E2=80=A6 Warner > On Feb 27, 2015, at 8:30 AM, Ed Maste wrote: >=20 > On 27 February 2015 at 10:12, Benjamin Kaduk = wrote: >>=20 >> As of r278229, the kernel is compiled with -fwrapv, so signed integer >> overflow in the FreeBSD kernel is defined behavior. >=20 > This is primarily a workaround to accommodate existing code though; > it's not a result of an explicit decision that we want to support > signed integer overflow. >=20 > -Ed >=20 --Apple-Mail=_DFD6C50D-D254-4C7D-92AB-B7BEA1A18D26 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJU8JFYAAoJEGwc0Sh9sBEAas0P+wdoK/4EuuCxMhaGIF9YED7Q m7HHQf5LUIoo1HezWuIlhSD0i6QN6gG2cYfY7S/PKgfP4QiRDAlVDSt2oW4HPfEN mFGZ200IQkTomZVYcPsDP+2CP11jwLPqsEpvoSQovTYePMYQ2lYTKlrdnmkqeqee YXnnvCSwSDBNiFvrPgaRxnOuqmqYdx/z/CEgMrwtsZpJ5vHzI2GhSr+/9YFLgFaG 526o/f9vnf8PRDGVLWGxoTIfR5A8wEHmOl91V2e359ZSy7KXCj6CVEQLfd/iHAT0 5QC+vnv8Idv6jlYsGZbBM7hSZtufd+YuAaAo79zSzmn9U1yfvI26TfWTcO0cF5Ja q3U2bZE1Y01GSwWZu5eHk/v9R8b7hbU3Fi5EzN/S6MyDm5eur4/zF7eCZP+oQwu7 wpd4n7NN5aM/MbE+buFq3MWmW2Mq8Ejr6GP5n01Z8oloUul3UYvq6KeYREGAjsdN 6mqKkLAFwz/5WmCMu3yoesT/B+C8mjMheEoEC2hpsb9SUnzyyS2Mf9VOkSyvtYXa rhv9h1oGousRsWTQEhJy2Zy4I29PGxvi1IaA/0bGKB1AMnz0UW7vIGJDPauZn/yd 7j7UeGEL+s29mmXXhwe1HPpw7fh+jZ57wNCvdse02TXiRoq6xhCdl+sHAKiBhTmG OAyvb2lnBaVysEBw99MR =nX+e -----END PGP SIGNATURE----- --Apple-Mail=_DFD6C50D-D254-4C7D-92AB-B7BEA1A18D26--