Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 24 May 2010 06:33:15 +0000 (UTC)
From:      Ulrich Spoerlein <uqs@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r208484 - head/bin/pax
Message-ID:  <201005240633.o4O6XFjV015258@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: uqs
Date: Mon May 24 06:33:14 2010
New Revision: 208484
URL: http://svn.freebsd.org/changeset/base/208484

Log:
  Fix back references in substitute command for pax(1)
  
  pax(1) was trying to copy the back-referenced data from
  the match pattern, not the matched data.
  
  PR:		bin/118132
  Obtained from:	Debian bug #451361
  Reviewed by:	jilles
  MFC after:	3 weeks

Modified:
  head/bin/pax/pat_rep.c

Modified: head/bin/pax/pat_rep.c
==============================================================================
--- head/bin/pax/pat_rep.c	Mon May 24 06:26:38 2010	(r208483)
+++ head/bin/pax/pat_rep.c	Mon May 24 06:33:14 2010	(r208484)
@@ -76,7 +76,7 @@ static char * range_match(char *, int);
 #ifdef NET2_REGEX
 static int resub(regexp *, char *, char *, char *);
 #else
-static int resub(regex_t *, regmatch_t *, char *, char *, char *);
+static int resub(regex_t *, regmatch_t *, char *, char *, char *, char *);
 #endif
 
 /*
@@ -929,7 +929,7 @@ rep_name(char *name, int *nlen, int prnt
 #			ifdef NET2_REGEX
 			if ((res = resub(pt->rcmp,pt->nstr,outpt,endpt)) < 0) {
 #			else
-			if ((res = resub(&(pt->rcmp),pm,pt->nstr,outpt,endpt))
+			if ((res = resub(&(pt->rcmp),pm,inpt,pt->nstr,outpt,endpt))
 			    < 0) {
 #			endif
 				if (prnt)
@@ -1071,7 +1071,7 @@ resub(regexp *prog, char *src, char *des
  */
 
 static int
-resub(regex_t *rp, regmatch_t *pm, char *src, char *dest,
+resub(regex_t *rp, regmatch_t *pm, char *orig, char *src, char *dest,
 	char *destend)
 {
 	char *spt;
@@ -1121,7 +1121,7 @@ resub(regex_t *rp, regmatch_t *pm, char 
 		 */
 		if (len > (destend - dpt))
 			len = destend - dpt;
-		if (l_strncpy(dpt, src + pmpt->rm_so, len) != len)
+		if (l_strncpy(dpt, orig + pmpt->rm_so, len) != len)
 			return(-1);
 		dpt += len;
 	}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201005240633.o4O6XFjV015258>