From owner-svn-ports-all@FreeBSD.ORG  Tue Jan 14 13:14:20 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id BD1B722D;
 Tue, 14 Jan 2014 13:14:20 +0000 (UTC)
Received: from mail-qe0-x229.google.com (mail-qe0-x229.google.com
 [IPv6:2607:f8b0:400d:c02::229])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 45D74138A;
 Tue, 14 Jan 2014 13:14:20 +0000 (UTC)
Received: by mail-qe0-f41.google.com with SMTP id gh4so8611245qeb.14
 for <multiple recipients>; Tue, 14 Jan 2014 05:14:19 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=g44Hd/KUwNqn8NGJcPEFUKImpnuY98rf+dhgP5RFUlI=;
 b=SJedJV59/+79YyCVX3JrGQqdwRd+boeSjk06o5qbFpJoTI8lQFlm83UYcD30jeng6D
 bypMtadAURHGCEiPbO3B4Q/5oAeFI40Xxbko+Sb2Xuj4/zAhUgm9VFtf6f94+AITYmuK
 2DA7iD+B5/m4Zqor/phQCLD6tgM6DwLMTk0t0tL2ThPWia9X4eUUsarKB2CYI1MbzbbN
 SO2gAW2TkStSirLIOCEMz1VanHt0d/10P+HFPg+5Z3JaacblaLRtkpC7M0ShAiMSYqir
 cHaPsMjZ4KbWRS9PAg0Et1Z2buvns/dk9skULwxMF79ACgaxZD4XGOP7laIQ8ybfs0Fq
 hLJQ==
MIME-Version: 1.0
X-Received: by 10.229.90.199 with SMTP id j7mr2813171qcm.14.1389705259517;
 Tue, 14 Jan 2014 05:14:19 -0800 (PST)
Sender: takatsu.tomonari@gmail.com
Received: by 10.96.202.40 with HTTP; Tue, 14 Jan 2014 05:14:19 -0800 (PST)
In-Reply-To: <20140113082949.GB8735@FreeBSD.org>
References: <201401010649.s016nJ4w004860@svn.freebsd.org>
 <20140113082949.GB8735@FreeBSD.org>
Date: Tue, 14 Jan 2014 22:14:19 +0900
X-Google-Sender-Auth: Zs0BssOzwHlC1Z7pkcpfwCAVeu0
Message-ID: <CANaE3C-Dy18HAiXhFuhiHyM7GoKPqNAHtSd4OHHwHGp_bNZb=g@mail.gmail.com>
Subject: Re: svn commit: r338361 - in head/devel/silentbob: . files
From: TAKATSU Tomonari <tota@FreeBSD.org>
To: Alexey Dokuchaev <danfe@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers <ports-committers@freebsd.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Jan 2014 13:14:20 -0000

2014/1/13 Alexey Dokuchaev <danfe@freebsd.org>:
> On Wed, Jan 01, 2014 at 06:49:19AM +0000, TAKATSU Tomonari wrote:
>> New Revision: 338361
>> URL: http://svnweb.freebsd.org/changeset/ports/338361
>>
>> +PORTDOCS=    README
> [...]
>> +.if ${PORT_OPTIONS:MDOCS}
>>  post-install:
>> -.if !defined(NOPORTDOCS)
>> -     @${MKDIR} ${DOCSDIR}
>> -     @${INSTALL_DATA} ${WRKSRC}/README ${DOCSDIR}
>> -     @${INSTALL_DATA} ${WRKSRC}/doc/* ${DOCSDIR}
>> +     @${MKDIR} ${STAGEDIR}${DOCSDIR}
>> +     @${INSTALL_DATA} ${WRKSRC}/${PORTDOCS} ${STAGEDIR}${DOCSDIR}
>
> For a simple cases like this one (when docs are not being built and are just
> a lonely README file), once staged, .if ${PORT_OPTIONS:MDOCS} is no longer
> necessary (and would allow you to remove .include <bsd.port.options.mk>).
>
> Please note that INSTALL_* commands should not be muted (muting MKDIR is
> fine), thank you.
>
> ./danfe

Thank you for pointing out my mistakes.
I'll fix with following patch.

Index: Makefile
===================================================================
--- Makefile    (revision 339683)
+++ Makefile    (working copy)
@@ -18,17 +18,13 @@

 OPTIONS_DEFINE=        DOCS

-.include <bsd.port.options.mk>
-
 post-patch:
        @${RM} ${WRKSRC}/CMakeCache.txt
        @${REINPLACE_CMD} -e
's|/usr/lib/silent_bob/|${PREFIX}/lib/silent_bob/|' \
                ${WRKSRC}/src/init.cxx

-.if ${PORT_OPTIONS:MDOCS}
 post-install:
        @${MKDIR} ${STAGEDIR}${DOCSDIR}
-       @${INSTALL_DATA} ${WRKSRC}/${PORTDOCS} ${STAGEDIR}${DOCSDIR}
-.endif
+       ${INSTALL_DATA} ${WRKSRC}/${PORTDOCS} ${STAGEDIR}${DOCSDIR}

 .include <bsd.port.mk>


Please review it.

Regards,

-- 
TAKATSU Tomonari