From owner-svn-ports-head@freebsd.org Thu Nov 12 07:07:42 2015 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1AFC6A2D110; Thu, 12 Nov 2015 07:07:42 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wm0-x22f.google.com (mail-wm0-x22f.google.com [IPv6:2a00:1450:400c:c09::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id ADAB015B7; Thu, 12 Nov 2015 07:07:41 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by wmdw130 with SMTP id w130so141407522wmd.0; Wed, 11 Nov 2015 23:07:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=eo0lzq/CJMZNHDAtUUL+d7YxDGqM3OJDm7MzMeCmvXo=; b=dRmJgKissPURYU8OESq0fd3/frFxvC1YyqpUFDHePrW1HCksZa5bLYWdR24tHzKIJo JVi26eg4CyIacslz3zN02qNXiiWB8dZLHgbsMcgp83H/TrJr5N/qeYrMBwLtwg/5eR9O 3aqD4x16W1pGwvDvM3oirhEgDqZobMSxxkySfm1JlQVzKS+4Nz5Fh3gy0Fx6uxnkaIpl U/EvWW7HqjUOvQKjPh95tE0E3UbOJmiiKL9fFOXspbhV0fwK8sDQE+i3RV6uRavL1ZDp 1v4N06oVGdxgz0gZQzoSskEGjHkMqRqQ8d7LkFq92LfQDpEExa/L4NjwbSsL2nRklkfd hcsg== X-Received: by 10.28.170.65 with SMTP id t62mr16683061wme.1.1447312060200; Wed, 11 Nov 2015 23:07:40 -0800 (PST) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id 71sm13375836wmm.24.2015.11.11.23.07.37 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Nov 2015 23:07:39 -0800 (PST) Sender: Baptiste Daroussin Date: Thu, 12 Nov 2015 08:07:34 +0100 From: Baptiste Daroussin To: Alexey Dokuchaev Cc: Jung-uk Kim , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r401297 - head/databases/firebird25-server Message-ID: <20151112070734.GP10134@ivaldir.etoilebsd.net> References: <201511112104.tABL4b3j045859@repo.freebsd.org> <20151111221237.GO10134@ivaldir.etoilebsd.net> <5643C272.5080309@FreeBSD.org> <20151112020446.GA43902@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tjOMJDssiV0CZSJH" Content-Disposition: inline In-Reply-To: <20151112020446.GA43902@FreeBSD.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Nov 2015 07:07:42 -0000 --tjOMJDssiV0CZSJH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 12, 2015 at 02:04:46AM +0000, Alexey Dokuchaev wrote: > On Wed, Nov 11, 2015 at 05:34:26PM -0500, Jung-uk Kim wrote: > > [...] > > Yes, I understand all of the above issues. However, what I dislike is > > the fact that USES=3Dlibedit implies USES=3Dlocalbase. Therefore, it > > unconditionally spams CFLAGS, CPPFLAGS, CXXFLAGS, and LDFLAGS. >=20 > Hmm, looks like this ".include "${USESDIR}/localbase.mk" line should not > be needed: `devel/libedit' installs libdata/pkgconfig/libedit.pc and its > consumers should use pkgconf(1) instead of expecting headers and libraries > at some default paths. >=20 > The problem I guess is that no one wants to patch consumer ports to use > pkgconf(1) for libedit. :-( >=20 Except that pkg-config would also add to cflags -I... which would be worse = than -isystem ... So what you do propose won't help at all. Best regards, bapt --tjOMJDssiV0CZSJH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlZEOrYACgkQ8kTtMUmk6EwinQCdEP4N9OsTBYvs04Grt9GAVX0O ETsAniTz7t/Ud8Ff2byIcIM/EuPVv2Qm =YF9S -----END PGP SIGNATURE----- --tjOMJDssiV0CZSJH--