Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 21 May 2013 10:58:17 -0500
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        gahr@FreeBSD.org
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r318663 - head/Mk
Message-ID:  <519B9999.4010004@FreeBSD.org>
In-Reply-To: <20130521155501.GG20911@gahrfit.gahr.ch>
References:  <201305210859.r4L8x3qi001432@svn.freebsd.org> <519B95F3.6030901@FreeBSD.org> <20130521155501.GG20911@gahrfit.gahr.ch>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
------enig2LEQBKRPQEIDUWTSWUBFQ
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 5/21/2013 10:55 AM, Pietro Cerutti wrote:
> On 2013-May-21, 10:42, Bryan Drewery wrote:
>> On 5/21/2013 3:59 AM, Pietro Cerutti wrote:
>>> Author: gahr
>>> Date: Tue May 21 08:59:02 2013
>>> New Revision: 318663
>>> URL: http://svnweb.freebsd.org/changeset/ports/318663
>>>
>>> Log:
>>>   - Switch default version of Tcl/Tk from 8.5 to 8.6
>>>  =20
>>>   PR:		178369
>>>   Submitted by:	gahr
>>>   Approved by:	portmgr (after exp-run)
>>>
>>> Modified:
>>>   head/Mk/bsd.tcl.mk
>>>
>>> Modified: head/Mk/bsd.tcl.mk
>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
>>> --- head/Mk/bsd.tcl.mk	Tue May 21 08:56:40 2013	(r318662)
>>> +++ head/Mk/bsd.tcl.mk	Tue May 21 08:59:02 2013	(r318663)
>>> @@ -13,7 +13,7 @@ Tcl_Include_MAINTAINER=3D		mm@FreeBSD.org
>>>  #			  via the port or by the user via defined variable try to find t=
he highest
>>>  #			  stable installed version.
>>>  #			  Available values: yes 86+ 85+ 84+ 85 84
>>> -#			  NOTE: - default value 85 is used in case of USE_TCL=3Dyes
>>> +#			  NOTE: - default value 86 is used in case of USE_TCL=3Dyes
>>>  #
>>>  # USE_TCL_BUILD		- Add buildtime dependency on Tcl (tclsh).
>>>  #			  Available values: see USE_TCL
>>> @@ -28,12 +28,12 @@ Tcl_Include_MAINTAINER=3D		mm@FreeBSD.org
>>>  #			  a specific tclsh version may use this.
>>>  #			  The tclsh wrapper script installs into ${LOCALBASE}/bin/tclsh
>>>  #			  NOTE: - USE_TCL_WRAPPER and USE_TCL can be used together
>>> -#			        - ports using the wrapper should support default Tcl (8.=
5)
>>> +#			        - ports using the wrapper should support default Tcl (8.=
6)
>>>  ##
>>>  # INVALID_TCL_VER	- This variable contains a list of Tcl versions no=
t supported by the port.
>>> -#			  This setting is effective only when USE_TCL is set to a range =
(e.g. 84+)
>>> +#			  This setting is effective only when USE_TCL is set to a range =
(e.g. 85+)
>>>  # WITH_TCL_VER		- User defined global variable to set Tcl version
>>> -#			  This variable is effective only if USE_TCL is set to a range (=
e.g. 84+)
>>> +#			  This variable is effective only if USE_TCL is set to a range (=
e.g. 85+)
>>>  #			  and WITH_TCL_VER points inside that range.
>>>  #			  NOTE: INVALID_TCL_VER takes precedence
>>>  # <UNIQUENAME>_WITH_TCL_VER	- User defined port specific variable to=
 set Tcl version
>>> @@ -46,7 +46,7 @@ Tcl_Include_MAINTAINER=3D		mm@FreeBSD.org
>>>  #			  stable installed version.
>>>  #			  Avaliable values: yes 86+ 85+ 84+ 85 84
>>>  #			  NOTE: - overrides USE_TCL
>>> -#			        - default value 85 is used in case of USE_TK=3Dyes
>>> +#			        - default value 86 is used in case of USE_TK=3Dyes
>>>  #
>>>  # USE_TK_BUILD		- Add buildtime dependency on Tk (wish).
>>>  #			  Available values: see USE_TK
>>> @@ -61,12 +61,12 @@ Tcl_Include_MAINTAINER=3D		mm@FreeBSD.org
>>>  #			  a specific wish version may use this.
>>>  #			  The wish wrapper script installs into ${LOCALBASE}/bin/wish
>>>  #			  NOTE: - USE_TK_WRAPPER and USE_TK can be used together.
>>> -#			        - ports using the wrapper should support default Tk (8.5=
)
>>> +#			        - ports using the wrapper should support default Tk (8.6=
)
>>>  ##
>>>  # INVALID_TK_VER	- This variable contains a list of Tk versions not =
supported by the port
>>> -#			  This setting is effective only when USE_TK is set to a range (=
e.g. 84+)
>>> +#			  This setting is effective only when USE_TK is set to a range (=
e.g. 85+)
>>>  # WITH_TK_VER		- User defined global variable to set Tk version.
>>> -#			  This variable is effective only if USE_TK is set to a range (e=
=2Eg. 84+)
>>> +#			  This variable is effective only if USE_TK is set to a range (e=
=2Eg. 85+)
>>>  #			  and WITH_TK_VER points inside that range.
>>>  #			  NOTE: overrides WITH_TCL_VER.
>>>  # <UNIQUENAME>_WITH_TK_VER	- User defined port specific variable to =
set Tk version
>>> @@ -157,7 +157,7 @@ INVALID_TCL_VER:=3D	${INVALID_TK_VER}
>>>  #
>>>  . if defined(USE_TCL)
>>> =20
>>> -_TCL_DEFAULT_VERSION=3D		85
>>> +_TCL_DEFAULT_VERSION=3D		86
>>
>> Would you consider adding TCL_DEFAULT_VERSION?=3D 86 instead? I would =
like
>> to default to 85 still on my systems.
>=20
> Can't you use WITH_TCL_VER / WITH_TK_VER for that?
>=20
>=20

Missed that. Thanks.

Doesn't help that all of the bsd.LANG.mk us different conventions.


--=20
Regards,
Bryan Drewery


------enig2LEQBKRPQEIDUWTSWUBFQ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRm5mZAAoJEG54KsA8mwz56NwP/25qfmdZlvz/Ql8RtxQGp+1A
6wlN9TEalmskVubOu5wdhgFZGZaHFsdVAWv2W5Ur3NeraL1Nqare0nMbQQ00pUHk
T5N2HQUMZqFPb/yGIXXLQK76qTlY+zi924qjbeRN8DVL2ZIoOeqc/YR4hlP2CNgV
ClED7yGyLfXli/2WFeJL5JGohzuTpqPN9X5BV6yXSokTmSGJA0AyVD5CSq3TXrqQ
BLLKTjfS2rOvjGBYYH2P/w+5Yjc81WzGQ32RDhBAeJB848R2KJRBn4zNFZxeA5qK
7IpNHML6Pjko0WiHXS2OnA7O40WVtdEtCUO/SWmjwCgjopMc4nb5ERMXPAL+TumY
Tz+nJpD9IwxgiWr487uaTOj03vOF+o0mDEeqQtpf30VwG5rpD81RyQA588WJsDcR
61S37lmxRWi7t66nxo3FRPVP7nd8pWtGUI3trZ+JgV82fAJR82xwHZg8q9Kb0Jah
g3HY1kG7Y1STsl+s4wXKXc99X68WIXxOKrYck8ledsobyWfdZKIVzG2KuE5cU502
xCyY03jLlCo62ByoWzqEw0nfk0hqB9zIgbyr2Igeq8ZYW+7e05FKfITXqQwBlmiU
OiacsoioBvvXIys1JOGB+EMP1dt5mcfV8bbs7ezcMx2vGqOHM5mDpY9EfYG/ZCZw
a04629vlcXrVZFtFeR31
=cuiq
-----END PGP SIGNATURE-----

------enig2LEQBKRPQEIDUWTSWUBFQ--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?519B9999.4010004>