From owner-freebsd-ports-bugs@FreeBSD.ORG Wed May 18 14:20:07 2005 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 82DE516A4CE for ; Wed, 18 May 2005 14:20:07 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 65D4243DA0 for ; Wed, 18 May 2005 14:20:06 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j4IEK2XX010385 for ; Wed, 18 May 2005 14:20:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j4IEK21P010384; Wed, 18 May 2005 14:20:02 GMT (envelope-from gnats) Resent-Date: Wed, 18 May 2005 14:20:02 GMT Resent-Message-Id: <200505181420.j4IEK21P010384@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jeremy Chadwick Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0AEEA16A4CE for ; Wed, 18 May 2005 14:19:24 +0000 (GMT) Received: from mx1.parodius.com (mx1.parodius.com [64.62.145.229]) by mx1.FreeBSD.org (Postfix) with ESMTP id A9F0A43DA9 for ; Wed, 18 May 2005 14:19:23 +0000 (GMT) (envelope-from jdc@pentarou.parodius.com) Received: from pentarou.parodius.com (localhost [127.0.0.1]) by mx1.parodius.com (8.13.3/8.13.3) with ESMTP id j4IEJFC3012560 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 18 May 2005 07:19:15 -0700 (PDT) (envelope-from jdc@pentarou.parodius.com) Received: (from jdc@localhost) by pentarou.parodius.com (8.13.3/8.13.3/Submit) id j4IEJFSl012559; Wed, 18 May 2005 07:19:15 -0700 (PDT) (envelope-from jdc) Message-Id: <200505181419.j4IEJFSl012559@pentarou.parodius.com> Date: Wed, 18 May 2005 07:19:15 -0700 (PDT) From: Jeremy Chadwick To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/81203: mail/mutt-devel -- MUTT_LITE should not include WITHOUT_NLS X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Jeremy Chadwick List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 May 2005 14:20:07 -0000 >Number: 81203 >Category: ports >Synopsis: mail/mutt-devel -- MUTT_LITE should not include WITHOUT_NLS >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed May 18 14:20:02 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Jeremy Chadwick >Release: FreeBSD 4.11-STABLE i386 >Organization: Parodius Networking >Environment: System: FreeBSD pentarou.parodius.com 4.11-STABLE FreeBSD 4.11-STABLE #0: Thu May 12 04:37:52 PDT 2005 root@pentarou.parodius.com:/usr/obj/usr/src/sys/PENTAROU i386 >Description: The addition of the MUTT_LITE knob is fantastic; however, use of this knob no longer allows an administrator to build a "lite" version of mutt _with_ support for multiple character sets (such as on our systems). I propose the WITHOUT_NLS=yes definition inside of the MUTT_LITE knob be removed; administrators can then say MUTT_LITE=true WITHOUT_NLS=true when building, which is consistent with nearly every other port in ports. I must stress this point, since MUTT_LITE breaks the "norm" in this respect. Most administrators who do not want multiple character set support define WITHOUT_NLS=true in /etc/make.conf anyways, i.e. every port on the system will not use iconv/gettext. :-) Either way, it's up for discussion. The port maintainer should be the one to make the call. >How-To-Repeat: n/a >Fix: If maintainer agrees, apply below patch. diff -ruN mutt-devel.orig/Makefile mutt-devel/Makefile --- mutt-devel.orig/Makefile Wed May 18 07:00:52 2005 +++ mutt-devel/Makefile Wed May 18 07:14:05 2005 @@ -96,7 +96,7 @@ PORTNAME= mutt-devel PORTVERSION= 1.5.9 -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES+= mail ipv6 .if defined(WITH_MUTT_NNTP) CATEGORIES+= news @@ -192,7 +192,6 @@ .if defined (MUTT_LITE) WITHOUT_MUTT_SGMLFORMAT= yes -WITHOUT_NLS= yes WITHOUT_MUTT_COMPRESSED_FOLDERS= yes WITHOUT_MUTT_QUOTE_PATCH= yes WITHOUT_MUTT_HTML= yes >Release-Note: >Audit-Trail: >Unformatted: