From owner-freebsd-gnome@FreeBSD.ORG Sat Mar 26 02:20:27 2005 Return-Path: Delivered-To: freebsd-gnome@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 161F016A4CE; Sat, 26 Mar 2005 02:20:27 +0000 (GMT) Received: from connectmail.carleton.ca (connectmail.carleton.ca [134.117.2.12]) by mx1.FreeBSD.org (Postfix) with ESMTP id CDA4543D54; Sat, 26 Mar 2005 02:20:26 +0000 (GMT) (envelope-from adamw@magnesium.net) Received: from [192.168.1.140] ([134.117.145.25]) by connectmail.carleton.ca (iPlanet Messaging Server 5.2 HotFix 2.02 (built Oct 21 2004)) with ESMTPSA id <0IDX009UWT6342@connectmail.carleton.ca>; Fri, 25 Mar 2005 21:20:27 -0500 (EST) Date: Fri, 25 Mar 2005 21:24:08 -0500 From: Adam Weinberger To: kde@freebsd.org, gnome@freebsd.org Message-id: <4244C7C8.60307@magnesium.net> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7BIT X-Accept-Language: en-us, en User-Agent: Mozilla Thunderbird 1.0.2 (Macintosh/20050317) Subject: KDE checks for xscreensaver-gnome in wrong place X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Mar 2005 02:20:27 -0000 kdeartwork3 and xscreensaver-kde do some incorrect GNOME-related checking. They both check to see if xscreensaver-gnome is installed by looking for ${X11BASE}/share/gnome/control-center-2.0/capplets/screensaver-properties.desktop But, that file is now ${X11BASE}/share/gnome/applications/gnome-screensaver-properties.desktop It needs to be changed in a number of places in kdeartwork3/Makefile and xscreensaver-kde/Makefile. It would seem to me that this change would be good to commit before 5.4 is tagged. As it stands now, kdeartwork3 cannot build with xscreensaver-gnome installed. Furthermore, the logic in kdeartwork3 seems a little weird. It checks to see whether xscreesaver or xscreensaver-gnome is installed, and then does the same thing in both cases. Is this intentional? # Adam -- Adam Weinberger adamw@magnesium.net || adamw@FreeBSD.org adamw@vectors.cx || adamw@gnome.org http://www.vectors.cx