From owner-svn-src-all@FreeBSD.ORG Fri Feb 27 15:56:11 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C6D6B1B3; Fri, 27 Feb 2015 15:56:11 +0000 (UTC) Received: from pmta2.delivery4.ore.mailhop.org (pmta2.delivery4.ore.mailhop.org [54.200.247.200]) by mx1.freebsd.org (Postfix) with ESMTP id 9D475DCD; Fri, 27 Feb 2015 15:56:11 +0000 (UTC) Received: from smtp4.ore.mailhop.org (172.31.36.112) by pmta2.delivery1.ore.mailhop.org id hu29qg20u50n; Fri, 27 Feb 2015 15:56:16 +0000 (envelope-from ) Received: from c-73-34-117-227.hsd1.co.comcast.net ([73.34.117.227] helo=ilsoft.org) by smtp4.ore.mailhop.org with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.82) (envelope-from ) id 1YRNGk-000072-Nf; Fri, 27 Feb 2015 15:56:02 +0000 Received: from revolution.hippie.lan (revolution.hippie.lan [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id t1RFu0ck018792; Fri, 27 Feb 2015 08:56:01 -0700 (MST) (envelope-from ian@freebsd.org) X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 73.34.117.227 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX1/dTGrYid+1vde2XoXjqn0Y Message-ID: <1425052560.1281.21.camel@freebsd.org> Subject: Re: svn commit: r279349 - head/sys/kern From: Ian Lepore To: Warner Losh Date: Fri, 27 Feb 2015 08:56:00 -0700 In-Reply-To: References: <201502270256.t1R2uxnv085328@svn.freebsd.org> <20150227082257.3fb1081c@bender.Home> <20150227202646.I2088@besplex.bde.org> Content-Type: text/plain; charset="windows-1251" X-Mailer: Evolution 3.12.10 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: Benjamin Kaduk , "src-committers@freebsd.org" , Ed Maste , "svn-src-all@freebsd.org" , Andrew Turner , Bruce Evans , "svn-src-head@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Feb 2015 15:56:11 -0000 On Fri, 2015-02-27 at 08:46 -0700, Warner Losh wrote: > Sure wish my code review got this much love… > > Warner > IMO, the biggest problem with phab reviews is advertising them. You can guess who might be interested and add them as reviewers. You can try posting a summary and the url to some mailing list. I wonder if it would be useful to have the system itself mail the summary line of every new review that's created to some list? It would probably need to be several lists -- I sure don't want to see every ports phab that gets created, but getting a single mail for every src review created wouldn't be too much. I don't know if that's a good idea or not, but the reason we reliably get post-commit reviews is because the changes reliably appear in front of everyone's eyes at that point. -- Ian > > On Feb 27, 2015, at 8:30 AM, Ed Maste wrote: > > > > On 27 February 2015 at 10:12, Benjamin Kaduk wrote: > >> > >> As of r278229, the kernel is compiled with -fwrapv, so signed integer > >> overflow in the FreeBSD kernel is defined behavior. > > > > This is primarily a workaround to accommodate existing code though; > > it's not a result of an explicit decision that we want to support > > signed integer overflow. > > > > -Ed > > >