From owner-svn-src-head@freebsd.org Sun Jul 8 16:14:20 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 587B3103564E; Sun, 8 Jul 2018 16:14:20 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BB5637C138; Sun, 8 Jul 2018 16:14:19 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-wr1-x444.google.com with SMTP id r16-v6so8497533wrt.11; Sun, 08 Jul 2018 09:14:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=fPhRJvaRxQGk++DXhggBg7BocmERMlqv0X7zWwgbGtw=; b=iZlyks4ZWr/Dq5JaDiQkH8mp295YGitCtpCTAq75wjG9yz4wXW/iQFLo0A0j6EEdfe 63Br3N444UbwWyxGAbqpA7rrGBAEqE3jhS1AhAF3jh6SefqKnTr3lMqDSQ0q4tECm56e 5uFfSO4TsUF7JykHuNCtFPBbnn9XusMZ9GvJDgVGk7mwSST7DiAJ5GazG1k/IbjGKs8l zanQdIz0+APp31eSyxdZRIeb+Mx7dm3WPnT7hM/hzSCpGzB5Um+JQKWGeHBOw+CFbZZD OFvuPnCM6+MRb/6HGXukQB4oy+6AyyrdDLYK+nCTb85vpA0joUZ4fMeU8QvI3KawQGUF SYMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=fPhRJvaRxQGk++DXhggBg7BocmERMlqv0X7zWwgbGtw=; b=gIlvV0XmsEwabCsdgALK+N2FcfQrG2riKaWIhZwGZOnpP29BwmEDcIe8v9H5Holn77 6nC6YgW0EUUKQquClfz00TYPMA2JJW3y+tkJSzik29hL7FNt8SrNHbRXjGsb55+vlHs/ X1z9ovTNF3L8uk4/CEGABHHApewmhbCJSEkEDsTu++GkH9rSod2EC1BprBiGgRUEROti x04I19CS2CFlo8rR7lOhzct7Dxw7ZOVkQIUQddVmSBFrDryI79wwH28+qTV3mafdvou/ plLRqRs022paGjHGsHctoRbo0sfdG5sYnu4ntpCSwe1fT1wIHM7x2bnaJ6mDvtluvVzb kWYA== X-Gm-Message-State: APt69E26JTluGR5DQW9/BrbRLQYXHEJq5RwX0wae44HZ7EchwgIeuuN3 GBGn5lLtA9CT2mGokPCkJ6tu2mmJ X-Google-Smtp-Source: AAOMgpfzGl2HAOK/ez0MORCwNslDQ10r86iM6YydImnV6PuYBuAG1ImRBbVbMtVKF9zAWnl5d97d5A== X-Received: by 2002:adf:a49a:: with SMTP id g26-v6mr12912277wrb.91.1531066458685; Sun, 08 Jul 2018 09:14:18 -0700 (PDT) Received: from pesky (174.red-81-43-74.staticip.rima-tde.net. [81.43.74.174]) by smtp.gmail.com with ESMTPSA id j131-v6sm14604965wmb.35.2018.07.08.09.14.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Jul 2018 09:14:17 -0700 (PDT) Sender: Mark Johnston Date: Sun, 8 Jul 2018 12:14:15 -0400 From: Mark Johnston To: Warner Losh Cc: Sean Bruno , Andrew Turner , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334880 - head/sys/dev/vnic Message-ID: <20180708161415.GD18193@pesky> References: <201806091447.w59ElnpU026396@repo.freebsd.org> <20180707174351.GA95934@pesky> <20180708152621.GB18193@pesky> <5483bcd6-f3bc-8b78-ee51-3bf3c2a1c2da@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jul 2018 16:14:20 -0000 On Sun, Jul 08, 2018 at 09:58:35AM -0600, Warner Losh wrote: > On Sun, Jul 8, 2018 at 9:55 AM, Sean Bruno wrote: > > > > > > > On 07/08/18 09:26, Mark Johnston wrote: > > > On Sun, Jul 08, 2018 at 09:10:27AM -0600, Sean Bruno wrote: > > >> > > >> > > >> On 07/07/18 11:43, Mark Johnston wrote: > > >>> On Sat, Jun 09, 2018 at 02:47:49PM +0000, Andrew Turner wrote: > > >>>> Author: andrew > > >>>> Date: Sat Jun 9 14:47:49 2018 > > >>>> New Revision: 334880 > > >>>> URL: https://svnweb.freebsd.org/changeset/base/334880 > > >>>> > > >>>> Log: > > >>>> In the ThunderX BGX network driver we were skipping the NULL > > terminator > > >>>> when parsing the phy type, however this is included in the length > > returned > > >>>> by OF_getprop. To fix this stop ignoring the terminator. > > >>>> > > >>>> PR: 228828 > > >>>> Reported by: sbruno > > >>>> Sponsored by: DARPA, AFRL > > >>> > > >>> This seems to break vnic on packet.net ThunderXs. In particular, VF > > >>> creation fails. It seems the problem in my case is that there are > > >>> multiple PHY devices in the device tree, e.g., xfi@0, xfi@1. With > > this > > >>> change, bgx_fdt_phy_name_match() fails to match against any device > > >>> containing a unit address in the node name. > > >>> > > >> > > >> > > >> Huh ... this was *required* to get the ThunderXs we have in the FreeBSD > > >> cluster to work at all. o.0 > > >> > > >> I guess "someone" needs to contact "someone" to figure out which is > > >> correct or we need to replace our FreeBSD cluster machines with ones > > >> that work like the packet.net machines? > > > > > > I think the current code works fine if there's only one PHY device, so > > > my problem is probably just the result of having a different hardware > > > setup. We can probably fix the code to handle both cases. Could you > > > mail me the output of "ofwdump -ap" from the cluster machine? > > > > > > > > > > > > I dropped the output here: > > https://people.freebsd.org/~sbruno/ofwdump.txt > > > Ian's method is better. But Ian's question is better: are there not > phandles to find this stuff? Names in FDT are kinda meaningless most of the > time (I say kinda here to gloss over a laundry list of exceptions that PHY > finding typically does not fall into). Sean's output shows why the current code works for him. In my case the bgx subnodes don't contain a qlm-mode property, so we're falling back to name matching: Node 0x891c: bgx0 #address-cells: 00 00 00 01 #size-cells: 00 00 00 00 reg: 00 00 80 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 Node 0x8ad8: xfi@0 reg: 00 00 00 00 local-mac-address: fc 15 b4 97 48 b7 phy-handle: 00 00 00 75 Node 0x8b34: xfi@1 reg: 00 00 00 01 local-mac-address: fc 15 b4 97 48 b8 phy-handle: 00 00 00 76 Being unfamiliar with FDT, could I ask you to explain how the code could be using phandles to find the PHYs?