From owner-freebsd-hardware@FreeBSD.ORG  Sat Jun 12 12:46:50 2004
Return-Path: <owner-freebsd-hardware@FreeBSD.ORG>
Delivered-To: freebsd-hardware@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 26A7D16A4CE; Sat, 12 Jun 2004 12:46:50 +0000 (GMT)
Received: from smsgw.vianetworks.ch (smsgw.vianetworks.ch [146.228.10.65])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 6A7E843D46; Sat, 12 Jun 2004 12:46:49 +0000 (GMT)
	(envelope-from mw@smsgw.vianetworks.ch)
Received: from smsgw.vianetworks.ch (localhost.kpnqwest.ch [127.0.0.1])
	by smsgw.vianetworks.ch (8.12.10/8.12.6) with ESMTP id i5CCjThm011660;
	Sat, 12 Jun 2004 14:45:29 +0200 (CEST)
	(envelope-from mw@smsgw.vianetworks.ch)
Received: (from mw@localhost)
	by smsgw.vianetworks.ch (8.12.10/8.12.6/Submit) id i5CCjTOZ011659;
	Sat, 12 Jun 2004 14:45:29 +0200 (CEST)
Message-Id: <200406121245.i5CCjTOZ011659@smsgw.vianetworks.ch>
In-Reply-To: <200406111703.14772.mistry.7@osu.edu>
To: Anish Mistry <mistry.7@osu.edu>
Date: Sat, 12 Jun 2004 14:45:28 +0200 (CEST)
Sender: mw@smsgw.vianetworks.ch
From: Markus Wild <mwild@vianetworks.ch>
X-NCC-RegID: ch.vianetworks
X-Mailer: ELM [version 2.4ME+ PL99b (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
cc: Markus Wild <mwild@vianetworks.ch>
cc: freebsd-hardware@freebsd.org
Subject: Re: Fix for Logitech DiNovo cordless mouse [PATCH]
X-BeenThere: freebsd-hardware@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: General discussion of FreeBSD hardware
	<freebsd-hardware.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hardware>,
	<mailto:freebsd-hardware-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hardware>
List-Post: <mailto:freebsd-hardware@freebsd.org>
List-Help: <mailto:freebsd-hardware-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hardware>,
	<mailto:freebsd-hardware-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 12 Jun 2004 12:46:50 -0000

Hm, I had a look through the patched files, and one thing that sprung
to my eyes: the FreeBSD hid_report_size(() function is currently used
to both return the size of a report, as well as setting the device
report ID (the ID parameter is of type "out"). This ID is later used
to match incoming reports to the device. With the suggested
changes, this parameter changes to being of type "in", i.e. the 
function no longer returns the ID information to the calling function.
This would certainly generate a compile time warning (if not error)
for ums.c, and while uhid.c has been syntactically changed, I now see
no place where sc->sc_iid, sc->sc_oid, sc->sc_fid would be initialized
after applying the change. I assume the NetBSD code in itself is sound,
so perhaps we're just missing additional files now that would also need
to be changed for FreeBSD?

Cheers,
Markus