From owner-cvs-src@FreeBSD.ORG Mon Apr 23 20:48:15 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7441816A40B for ; Mon, 23 Apr 2007 20:48:15 +0000 (UTC) (envelope-from SRS0=8360544638c3f8ee760cf8ff56bc0739fa4c4ca0=314=es.net=oberman@es.net) Received: from postal1.es.net (postal2.es.net [198.128.3.206]) by mx1.freebsd.org (Postfix) with ESMTP id 3518B13C468 for ; Mon, 23 Apr 2007 20:48:15 +0000 (UTC) (envelope-from SRS0=8360544638c3f8ee760cf8ff56bc0739fa4c4ca0=314=es.net=oberman@es.net) Received: from ptavv.es.net (ptavv.es.net [198.128.4.29]) by postal2.es.net (Postal Node 2) with ESMTP (SSL) id CYT75214; Mon, 23 Apr 2007 13:48:14 -0700 Received: from ptavv.es.net (ptavv.es.net [127.0.0.1]) by ptavv.es.net (Tachyon Server) with ESMTP id 938B64506A; Mon, 23 Apr 2007 13:48:14 -0700 (PDT) To: "Bjoern A. Zeeb" In-Reply-To: Your message of "Mon, 23 Apr 2007 20:32:10 -0000." <20070423202957.W36917@maildrop.int.zabbadoz.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_1177361294_26194P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Mon, 23 Apr 2007 13:48:14 -0700 From: "Kevin Oberman" Message-Id: <20070423204814.938B64506A@ptavv.es.net> Cc: "George V. Neville-Neil" , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet6 route6.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2007 20:48:15 -0000 --==_Exmh_1177361294_26194P Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > Date: Mon, 23 Apr 2007 20:32:10 +0000 (UTC) > From: "Bjoern A. Zeeb" > > On Mon, 23 Apr 2007, Kevin Oberman wrote: > > Hi, > > >> From: "George V. Neville-Neil" > >> Date: Mon, 23 Apr 2007 09:32:04 +0000 (UTC) > >> Sender: owner-cvs-all@freebsd.org > >> > >> gnn 2007-04-23 09:32:04 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/netinet6 route6.c > >> Log: > >> Turn off route header processing for now due to issues pointed out > >> by Philippe Biondi and Arnaud Ebalard. This is a temporary fix > >> until more discussion can be had on the exact risks involved in > >> allowing source routing in IPv6 > >> > >> Submitted by: itojun > >> Reviewed by: jinmei > >> MFC after: 1 day > >> > >> Revision Changes Path > >> 1.13 +7 -0 src/sys/netinet6/route6.c > > > > I forgot to mention (and not George's issue) is that a bit of work is > > needed on ipfw for IPv6 data types. I have hit several issues which I > > worked around, but, ATM, it can't differentiate between RH0 and RH2 in a > > filter. > > Just a five-minute-o-patch. I have not even compile time tested it. > > 'route' will still match any routing header. > 'rh0' should match rh0, and 'rh2' should match rh2. > > http://sources.zabbadoz.net/freebsd/ipv6/patches/patch-20070423-ipfw-rh2.patch > > Let me know if it works (or not;-) > > -- > Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT > Boy, that was fast. Unfortunately, it does not compile: cc -O2 -fno-strict-aliasing -pipe -c /usr/src/sbin/ipfw/ipfw2.c /usr/src/sbin/ipfw/ipfw2.c:1304: error: `EXT_RH0' undeclared here (not in a function) /usr/src/sbin/ipfw/ipfw2.c:1304: error: initializer element is not constant /usr/src/sbin/ipfw/ipfw2.c:1304: error: (near initialization for `ext6hdrcodes[6].x') /usr/src/sbin/ipfw/ipfw2.c:1304: error: initializer element is not constant /usr/src/sbin/ipfw/ipfw2.c:1304: error: (near initialization for `ext6hdrcodes[6]') /usr/src/sbin/ipfw/ipfw2.c:1305: error: `EXT_RH2' undeclared here (not in a function) /usr/src/sbin/ipfw/ipfw2.c:1305: error: initializer element is not constant /usr/src/sbin/ipfw/ipfw2.c:1305: error: (near initialization for `ext6hdrcodes[7].x') /usr/src/sbin/ipfw/ipfw2.c:1305: error: initializer element is not constant /usr/src/sbin/ipfw/ipfw2.c:1305: error: (near initialization for `ext6hdrcodes[7]') /usr/src/sbin/ipfw/ipfw2.c:1306: error: initializer element is not constant /usr/src/sbin/ipfw/ipfw2.c:1306: error: (near initialization for `ext6hdrcodes[8]') *** Error code 1 Stop in /usr/src/sbin/ipfw.c -- R. Kevin Oberman, Network Engineer Energy Sciences Network (ESnet) Ernest O. Lawrence Berkeley National Laboratory (Berkeley Lab) E-mail: oberman@es.net Phone: +1 510 486-8634 Key fingerprint:059B 2DDF 031C 9BA3 14A4 EADA 927D EBB3 987B 3751 --==_Exmh_1177361294_26194P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) Comment: Exmh version 2.5 06/03/2002 iD8DBQFGLRuOkn3rs5h7N1ERAgSdAJsH64D6m/Q2AiINMbB1jRHWnX1HrwCgsnL8 bG76MdnLH/R2ueRD+EtPisY= =iMOI -----END PGP SIGNATURE----- --==_Exmh_1177361294_26194P--