Date: Wed, 3 Mar 2004 22:27:14 +0100 From: Marc Olzheim <marcolz@stack.nl> To: Mark Murray <mark@grondar.org> Cc: current@freebsd.org Subject: Re: NULL vs 0 vs 0L bikeshed time Message-ID: <20040303212714.GA29655@stack.nl> In-Reply-To: <200403032039.i23Kd20w007779@grimreaper.grondar.org> References: <20040303164641.GA94900@stack.nl> <200403032039.i23Kd20w007779@grimreaper.grondar.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 03, 2004 at 08:39:02PM +0000, Mark Murray wrote:
> This is very good to know! What version of FreeBSD? What ports?
I ran it on FreeBSD 4.2 thru 4.9, on our compile server and on our
office-installserver, using a whole lot of "workstation" packages (like
kde*, gnome*) and development packages...
I didn't try it on my amd64 until now, or on any other FreeBSD 5.x
machine for that matter, so I don't know it that'll break anything, but
I will soon find out... :-P
I think it will fix more than it will break though.
On my FreeBSD 4.x systems, I only sporadically encountered problems
along the years and all have been fixed by the ports maintainers after
pointing them out to them...
Anyway, I'll run a portupgrade -af on my amd64 and see if anything
breaks...
> You likely have a boatload of local patches. Care to share them? :-)
I have no patches related to this, or maybe other local patches prevent
problems from arising... I'll look into it.
One other (unclean) patch I can think of to enable full warning -Werror
compilation of our own programs is this, which was fixed in 4.x, but
reappeared in 5.x, i.e. enabling the use of strftime("%+") ...
This does not fix any compile problems for the current ports though.
--- /usr/src/contrib/gcc/c-format.c Sat Jul 12 04:00:11 2003
+++ /usr/src/contrib/gcc/c-format.c Fri Feb 6 14:05:13 2004
@@ -817,7 +817,7 @@
{ "C", 0, STD_C99, NOLENGTHS, "-_0EOw", "o" },
{ "D", 0, STD_C99, NOLENGTHS, "", "2" },
{ "eVu", 0, STD_C99, NOLENGTHS, "-_0Ow", "" },
- { "FRTnrt", 0, STD_C99, NOLENGTHS, "", "" },
+ { "+FRTnrt", 0, STD_C99, NOLENGTHS, "", "" },
{ "g", 0, STD_C99, NOLENGTHS, "O-_0w", "2o" },
{ "G", 0, STD_C99, NOLENGTHS, "-_0Ow", "o" },
{ "h", 0, STD_C99, NOLENGTHS, "^#", "" },
Marc
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040303212714.GA29655>